Project

General

Profile

Actions

Task #1283

closed

Task #1205: NDNLP

NDNLP-TLV encode FragIndex and FragCount using nonNegativeInteger

Added by Junxiao Shi almost 11 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Faces
Target version:
Start date:
02/23/2014
Due date:
% Done:

100%

Estimated time:
2.00 h

Description

Change NDNLP-TLV spec and implementation to encode FragIndex and FragCount using nonNegativeInteger.

Sequence field still uses 8-octet fixed length number, because sequence number can wrap around, but nonNegativeNumber can increment forever.

Actions #1

Updated by Junxiao Shi almost 11 years ago

This is a decision from 20140221 conference call.

The original reason for using fixed length fields for FragIndex and FragCount is the concern on encoding performance.
ndn-cpp-dev has an efficient EncodingBuffer, which makes the above reason invalid.

There is no disadvantage in moving to variable length nonNegativeNumber encoding.

Actions #2

Updated by Junxiao Shi almost 11 years ago

  • Description updated (diff)
  • % Done changed from 0 to 30
Actions #3

Updated by Junxiao Shi almost 11 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 30 to 80
Actions #4

Updated by Alex Afanasyev almost 11 years ago

Let's be more consistent and update all counters to nonNegativeInteger... Less chances of having portability problems.

Actions #5

Updated by Alex Afanasyev almost 11 years ago

Also about wrapping around. Is it even feasible with 8-byte number? You gave me an argument before that it will take many years to do so...

Actions #6

Updated by Junxiao Shi almost 11 years ago

NdnlpSequence is not a counter. It should not be defined as nonNegativeInteger.

There is no known portability problem of using a fixed length field.

Actions #7

Updated by Alex Afanasyev almost 11 years ago

what is sequence number then? Is it fragment ID (which is unique for all fragments) or real sequence (which is increased by one for all segments)?

Actions #8

Updated by Junxiao Shi almost 11 years ago

20140224 conference call decides not to change NdnlpSequence field.

Actions #9

Updated by Junxiao Shi almost 11 years ago

  • % Done changed from 80 to 100
Actions #10

Updated by Junxiao Shi almost 11 years ago

  • Status changed from Code review to Closed
Actions

Also available in: Atom PDF