Project

General

Profile

Actions

Bug #1427

closed

NFD crash when requested to create unicast UDP face with non-unicast IP address

Added by Junxiao Shi over 10 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Faces
Target version:
Start date:
03/30/2014
Due date:
% Done:

100%

Estimated time:

Description

Steps to reproduce:

  1. sudo vi /etc/hosts, append a line:

    255.255.255.255 invalid-ip.bug1427.redmine.named-data.net
    
  2. start NFD

  3. execute any of the following

    nfdc create udp6://[fe80::]
    nfdc create udp4://255.255.255.255
    nfdc create udp://invalid-ip.bug1427.redmine.named-data.net
    

Expected: face creation fails, but NFD does not crash

Actual: FATAL: [Main] Failed to properly configure the socket. Check the address (connect: Invalid argument)


Related issues 1 (0 open1 closed)

Related to NFD - Bug #1421: Failed to create tcp6 and udp6 facesRejected03/27/2014

Actions
Actions #1

Updated by Junxiao Shi over 10 years ago

  • Related to Bug #1421: Failed to create tcp6 and udp6 faces added
Actions #2

Updated by Alex Afanasyev over 10 years ago

  • Assignee changed from Giulio Grassi to Anonymous

This is not face problem, this is problem of not handling exceptions in the manager. Whenever command is received and some action is performed, it should be enclosed in try/catch.

I'm reassigning this to Steve.

Actions #3

Updated by Anonymous over 10 years ago

  • Status changed from New to In Progress
Actions #4

Updated by Anonymous over 10 years ago

  • Status changed from In Progress to Code review

Please re-test using http://gerrit.named-data.net/#/c/617/ .

Note:

nfdc create udp4://255.255.255.255

successfully created a face for me prior to any changes. I've added a "best effort" check to block 255.255.255.255 and any of the known interfaces' broadcast addresses.

Actions #5

Updated by Junxiao Shi over 10 years ago

  • Description updated (diff)
  • % Done changed from 0 to 100

This bug is fixed in Ia3f0a9337f3d97c34388773eab05bc39ad6dd804 patchset 1, and can close when it's merged.

Actions #6

Updated by Anonymous over 10 years ago

  • Status changed from Code review to Closed
Actions

Also available in: Atom PDF