Actions
Bug #1494
closed
Catch potential exception in Faces
Start date:
04/16/2014
Due date:
% Done:
100%
Estimated time:
Description
Constructing Data or Interest packet can potentially cause an exception (e.g., when outer TLV is well-formed, but there is a problem with inner TLVs).
This exception needs to be properly handled and Face should be terminated.
Updated by Alex Afanasyev about 10 years ago
Actually. wireDecode for both Interest and Data can throw multiple different errors. For now, I would catch just std::runtime_error. Is there a problem with this?
Updated by Alex Afanasyev about 10 years ago
- Tracker changed from Task to Bug
- Priority changed from Normal to High
Updated by Junxiao Shi about 10 years ago
Don't catch std::runtime_error. It's too broad.
Catch ndn::Tlv::Error, the base class of all wireDecode raised errors.
Updated by Alex Afanasyev about 10 years ago
I think there could be other exceptions as well (it needs to be checked).
Updated by Alex Afanasyev about 10 years ago
- Status changed from New to Code review
- % Done changed from 0 to 100
Updated by Alex Afanasyev about 10 years ago
- Status changed from Code review to Closed
Actions