Project

General

Profile

Actions

Bug #1548

closed

rib/unregister sends malformed response

Added by Junxiao Shi almost 10 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
High
Category:
RIB
Target version:
Start date:
04/27/2014
Due date:
% Done:

100%

Estimated time:
0.40 h

Description

Steps to reproduce:

  1. start NFD and RIB daemon
  2. nfdc register /A 4 (substitute 4 with a valid FaceId)
  3. nfdc unregister /A 4

Expected: success

Actual: ERROR: Failed in unregistering name: Cost is forbidden but present (code: 500)

Actions #1

Updated by Junxiao Shi almost 10 years ago

  • Estimated time changed from 0.40 h to 0.40 h

Root cause of this problem:

RibManager::unregisterEntry is using ndn::nfd::RibRegisterCommand to validate parameters, and applies defaults to the parameters.

RibRegisterCommand::applyDefaultsToRequest sets Cost=0, which is later passed back in the response.

nfdc validates the response and finds that Cost field is forbidden in RibUnregisterCommand response.

Fix: RibManager::unregisterEntry should use ndn::nfd::RibUnregisterCommand to validate parameters.

Actions #2

Updated by Alex Afanasyev almost 10 years ago

  • Status changed from New to In Progress
  • Assignee set to Alex Afanasyev
  • Estimated time changed from 0.40 h to 0.40 h
Actions #3

Updated by Alex Afanasyev almost 10 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

Applied in changeset nfd|commit:ce7520edcc792bab282532a71269bd1eaa414d58.

Actions

Also available in: Atom PDF