Project

General

Profile

Actions

Bug #1630

closed

Support for protocol=nfd-0.1 is broken

Added by Alex Afanasyev over 10 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Management
Target version:
Start date:
05/20/2014
Due date:
% Done:

100%

Estimated time:
2.00 h

Description

NFD requires FaceId to be present in the control command, even for "self-registrations".

There are 2 ways to fix it:

  • fix the protocol, so it doesn't requires this, since it is more obvious to omit FaceId than specify FaceId=0, which may need additional comment or constant to clarify that face 0 is actually "self"

  • just update face-impl.hpp to add faceId as part of the parameters.

personally, I would go with protocol update.

Actions #1

Updated by Alex Afanasyev over 10 years ago

  • Description updated (diff)

I would like to proceed with the first approach (updating the protocol and control command). Any objections?

Actions #2

Updated by Junxiao Shi over 10 years ago

  • Assignee set to Junxiao Shi
  • Estimated time set to 2.00 h

I agree with changing the protocol to make FaceId optional in fib/add|remove-nexthop request, but the canonical representation (after applying defaults) is still FaceId=0 indicates "self".

I'll do the protocol update.

Actions #3

Updated by Junxiao Shi over 10 years ago

  • Status changed from New to In Progress
Actions #4

Updated by Junxiao Shi over 10 years ago

  • % Done changed from 0 to 20

Protocol update is complete.

Actions #5

Updated by Junxiao Shi over 10 years ago

  • % Done changed from 20 to 70

Library change is uploaded.

Actions #6

Updated by Junxiao Shi over 10 years ago

  • Status changed from In Progress to Code review
Actions #7

Updated by Junxiao Shi over 10 years ago

  • Status changed from Code review to Closed
  • % Done changed from 70 to 100
Actions

Also available in: Atom PDF