Bug #1630
closed
Support for protocol=nfd-0.1 is broken
100%
Description
NFD requires FaceId to be present in the control command, even for "self-registrations".
There are 2 ways to fix it:
fix the protocol, so it doesn't requires this, since it is more obvious to omit FaceId than specify FaceId=0, which may need additional comment or constant to clarify that face 0 is actually "self"
just update face-impl.hpp to add faceId as part of the parameters.
personally, I would go with protocol update.
Updated by Alex Afanasyev almost 10 years ago
- Description updated (diff)
I would like to proceed with the first approach (updating the protocol and control command). Any objections?
Updated by Junxiao Shi almost 10 years ago
- Assignee set to Junxiao Shi
- Estimated time set to 2.00 h
I agree with changing the protocol to make FaceId optional in fib/add|remove-nexthop request, but the canonical representation (after applying defaults) is still FaceId=0 indicates "self".
I'll do the protocol update.
Updated by Junxiao Shi almost 10 years ago
- Status changed from New to In Progress
Updated by Junxiao Shi almost 10 years ago
- Status changed from In Progress to Code review
Updated by Junxiao Shi almost 10 years ago
- Status changed from Code review to Closed
- % Done changed from 70 to 100