Project

General

Profile

Actions

Feature #2183

closed

LocalControlHeader: CachingPolicy

Added by Junxiao Shi over 9 years ago. Updated about 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Base
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
3.00 h

Description

Add CachingPolicy field in LocalControlHeader.

Support CachingPolicy feature in FaceEnableLocalControlCommand and FaceDisableLocalControlCommand


Related issues 3 (0 open3 closed)

Related to NFD - Feature #2184: faces/enable-local-control: CachingPolicyAbandoned

Actions
Blocks NFD - Feature #2185: Recognize CachingPolicy=NoCacheClosedJunxiao Shi

Actions
Blocks NFD - Feature #2182: InMemoryStorage for managementClosedYanbiao Li

Actions
Actions #1

Updated by Junxiao Shi over 9 years ago

  • Tracker changed from Task to Feature

Suggestion: change bool enableX, bool enableY into bit-wise OR'ed parameter, to make the API more readable.

Actions #2

Updated by Junxiao Shi over 9 years ago

Actions #3

Updated by Junxiao Shi over 9 years ago

Actions #4

Updated by Junxiao Shi over 9 years ago

  • Assignee set to Jiewen Tan
Actions #5

Updated by Junxiao Shi over 9 years ago

  • Related to Feature #2184: faces/enable-local-control: CachingPolicy added
Actions #6

Updated by Jiewen Tan about 9 years ago

Suggestion: change bool enableX, bool enableY into bit-wise OR'ed parameter, to make the API more readable.

May I ask where to start, i.e. which files I should modify or which directories I should put my own files in?

Actions #7

Updated by Jiewen Tan about 9 years ago

  • Status changed from New to In Progress
Actions #8

Updated by Junxiao Shi about 9 years ago

Look at nfd-local-control-header.hpp and how it's used in Interest and Data types.

I'm also thinking about making LocalControlHeader a Tag (see tag.hpp and tag-host.hpp), because it makes sense only in limited context.

Actions #9

Updated by Jiewen Tan about 9 years ago

Is NoCache a boolean type? I suppose that I should use prependBooleanBlock() to add a NoCache block to a CachingPolicy block.

Actions #10

Updated by Junxiao Shi about 9 years ago

Is NoCache a boolean type? I suppose that I should use prependBooleanBlock() to add a NoCache block to a CachingPolicy block.

I don't know about this area of code.
See spec for how the encoded packet looks like.

Actions #11

Updated by Jiewen Tan about 9 years ago

Junxiao Shi wrote:

Is NoCache a boolean type? I suppose that I should use prependBooleanBlock() to add a NoCache block to a CachingPolicy block.

I don't know about this area of code.
See spec for how the encoded packet looks like.

The spec says that the NoCache TLV has no value. I am not sure how to prepend a no value block to the CachingPolicy TLV.

Actions #12

Updated by Junxiao Shi about 9 years ago

The spec says that the NoCache TLV has no value. I am not sure how to prepend a no value block to the CachingPolicy TLV.

I'm unfamiliar with this area. I've asked ndn-lib. Please wait for an answer from the mailing list.

Actions #13

Updated by Jiewen Tan about 9 years ago

I can't find the test case for the nfd-local-control-header.hpp. Should I create one for it?

Actions #14

Updated by Junxiao Shi about 9 years ago

I can't find the test case for the nfd-local-control-header.hpp. Should I create one for it?

Yes, you must.

Actions #15

Updated by Jiewen Tan about 9 years ago

Actually, I found it is tested at the test case of interest, i.e. test-interest.cpp.

Actions #16

Updated by Jiewen Tan about 9 years ago

Undefined symbols for architecture x86_64:
  "ndn::nfd::CachingPolicy::CachingPolicy()", referenced from:
      ndn::nfd::LocalControlHeader::LocalControlHeader() in libndn-cxx.a(interest.cpp.2.o)
      ndn::nfd::LocalControlHeader::LocalControlHeader() in libndn-cxx.a(data.cpp.2.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

I encountered this linker error. Do you have any idea what causes it? I have implemented a CachingPolicy class and put it into the file nfd-local-control-header.hpp together with the LocalControlHeader class.

Actions #17

Updated by Alex Afanasyev about 9 years ago

You should share the code first (e.g., gerrit). Without seeing the code causing problem, I don't think anybody here would be able to give a good advise.

Actions #18

Updated by Jiewen Tan about 9 years ago

Alex Afanasyev wrote:

You should share the code first (e.g., gerrit). Without seeing the code causing problem, I don't think anybody here would be able to give a good advise.

Uploaded.

Actions #19

Updated by Jiewen Tan about 9 years ago

  • Status changed from In Progress to Code review
Actions #20

Updated by Junxiao Shi about 9 years ago

  • Status changed from Code review to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF