Project

General

Profile

Actions
Copy link

Bug #2301

closed

InMemoryStorage incorrectly iterates over entries

Added by Alex Afanasyev over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Alex Afanasyev
Category:
Utils
Target version:
v0.3
Start date:
12/15/2014
Due date:
% Done:

100%

Estimated time:

Description

In a few places, the following is done in InMemoryStorage:

Cache::iterator it = m_cache.begin();
while (it != m_cache.end()) {
  freeEntry(it);
  it++;
}

freeEntry(it) actually removes entry from m_cache, so it is invalidated and it++ doesn't make sense anymore.

Related issues 1 (0 open — 1 closed)

Related to ndn-cxx - Bug #2149: Heap-use-after-free in InMemoryStorageClosedJiewen Tan

Actions
Actions
Copy link
 #1

Updated by Davide Pesavento over 9 years ago

Could this be the cause of #2149?

Actions
Copy link
 #2

Updated by Alex Afanasyev over 9 years ago

Looks like it.

Actions
Copy link
 #3

Updated by Alex Afanasyev over 9 years ago

  • Related to Bug #2149: Heap-use-after-free in InMemoryStorage added
Actions
Copy link
 #4

Updated by Alex Afanasyev over 9 years ago

  • Status changed from In Progress to New
  • Assignee changed from Alex Afanasyev to Jiewen Tan
  • % Done changed from 50 to 0
Actions
Copy link
 #5

Updated by Alex Afanasyev over 9 years ago

  • Status changed from New to Code review
  • Assignee changed from Jiewen Tan to Alex Afanasyev
  • % Done changed from 0 to 100
Actions
Copy link
 #6

Updated by Alex Afanasyev over 9 years ago

  • Status changed from Code review to Closed
Actions
Copy link

Also available in: Atom PDF