Project

General

Profile

Actions

Task #2350

closed

NotificationSubscriber: use Signal

Added by Junxiao Shi almost 10 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
Utils
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
1.00 h

Description

In NotificationSubscriber, replace EventEmitter usage with Signal.

Actions #1

Updated by Junxiao Shi almost 10 years ago

  • Status changed from New to In Progress
  • Assignee set to Junxiao Shi
Actions #2

Updated by Junxiao Shi almost 10 years ago

  • % Done changed from 0 to 80

http://gerrit.named-data.net/1652

Notice is sent to ndn-lib nfd-dev.

No deadline is given because all changes must be merged at the same time.

Actions #3

Updated by Junxiao Shi almost 10 years ago

NFD and NLSR are affected https://travis-ci.org/yoursunny/ndn-cxx-breaks/builds/47715465.

I'll defer the fixes until after #2254 closes, so that I don't have to repeat the fix on two branches.

Actions #4

Updated by Junxiao Shi almost 10 years ago

Thanks @Vince for making the fix for NLSR http://gerrit.named-data.net/1656

One less thing to worry for me.

Actions #5

Updated by Junxiao Shi almost 10 years ago

http://gerrit.named-data.net/1667 fixes NFD.

Changes for ndn-cxx NFD NLSR must be merged together.

Actions #6

Updated by Junxiao Shi almost 10 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 80 to 100
Actions #7

Updated by Alex Afanasyev almost 10 years ago

There still be a time window when NFD/NLSR compilation will break: ndn-cxx needs to be merged first and then NFD and NLSR needs to get re-tested using the updated version of the library.

Actions #8

Updated by Junxiao Shi almost 10 years ago

There still be a time window when NFD/NLSR compilation will break: ndn-cxx needs to be merged first and then NFD and NLSR needs to get re-tested using the updated version of the library.

I understand. As discussed in 20141128 conference call, it's unfeasible to require every ndn-cxx Change to be backwards-compatible.

I have added Breaks marks to the COMMIT_MSG of this Change.

Actions #9

Updated by Junxiao Shi almost 10 years ago

  • Status changed from Code review to Closed
Actions

Also available in: Atom PDF