NFD

@Eric, how did you test the effectiveness of the fix?

I haven't been able to test it yet. I'm waiting for you to run it and return the results to me.

Reply to note-6:

Developer is responsible for testing the patch before submission.
This includes finding a way to test the scenario.

I'm asking for your method because I'm unsure how to perform the test using the automated system I have.

I can't think of a test method, as it would require there to be a problem with NFD. However, the changes were very minor, command was changed to command || exit and two more exit codes were added.

What about: run the scenario without installing the traffic generator. This shall cause the scenario to fail.

Although this is not a comprehensive test of the fix, it's better than not testing at all.

I don't have the lab environment set up and as a result, when I run the test, I just get SSH connection timed out errors and the like. How do you run the tests? Is it through a virtualized test environment?

I have explained to Eric on how to setup an integ environment. Eric agrees to test the patch before it can be approved.

I tested patch set 6 with the integration testing environment I created for #2436 (without ndn-traffic installed). The tests failed as expected:

======================================================================
FAIL: test_best_route (test_interest_loop.test_interest_loop)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vagrant/integration-tests/test_interest_loop/test_interest_loop.py", line 45, in test_best_route
    self.fail(self.errormsg[ret])
AssertionError: nfd-traffic failed

======================================================================
FAIL: test_broadcast (test_interest_loop.test_interest_loop)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vagrant/integration-tests/test_interest_loop/test_interest_loop.py", line 38, in test_broadcast
    self.fail(self.errormsg[ret])
AssertionError: nfd-traffic failed

======================================================================
FAIL: test_client_control (test_interest_loop.test_interest_loop)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vagrant/integration-tests/test_interest_loop/test_interest_loop.py", line 52, in test_client_control
    self.fail(self.errormsg[ret])
AssertionError: nfd-traffic failed

======================================================================
FAIL: test_ncc (test_interest_loop.test_interest_loop)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vagrant/integration-tests/test_interest_loop/test_interest_loop.py", line 59, in test_ncc
    self.fail(self.errormsg[ret])
AssertionError: nfd-traffic failed

I ran a test on patch set 7 by removing /usr/local/bin/nfd as suggested by Junxiao on Gerrit:

======================================================================
FAIL: test_best_route (test_interest_loop.test_interest_loop)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vagrant/integration-tests/test_interest_loop/test_interest_loop.py", line 44, in test_best_route
    self.fail(self.errormsg[ret])
AssertionError: add-nexthop failed

======================================================================
FAIL: test_broadcast (test_interest_loop.test_interest_loop)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vagrant/integration-tests/test_interest_loop/test_interest_loop.py", line 37, in test_broadcast
    self.fail(self.errormsg[ret])
AssertionError: add-nexthop failed

======================================================================
FAIL: test_client_control (test_interest_loop.test_interest_loop)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vagrant/integration-tests/test_interest_loop/test_interest_loop.py", line 51, in test_client_control
    self.fail(self.errormsg[ret])
AssertionError: add-nexthop failed

======================================================================
FAIL: test_ncc (test_interest_loop.test_interest_loop)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vagrant/integration-tests/test_interest_loop/test_interest_loop.py", line 58, in test_ncc
    self.fail(self.errormsg[ret])
AssertionError: add-nexthop failed