Project

General

Profile

Actions
Copy link

Bug #2630

closed

WebSocketChannel catches the wrong exceptions

Added by Davide Pesavento over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Wentao Shang
Category:
Faces
Target version:
v0.4
Start date:
Due date:
% Done:

100%

Estimated time:

Description

In several places, WebSocketChannel tries to catch an exception of type websocketpp::lib::error_code, but the correct type is websocketpp::exception.

However, instead of just fixing the catch statement, I suggest switching to the non-throwing variants of the relevant functions.

Actions
Copy link
 #1

Updated by Wentao Shang over 9 years ago

  • Assignee set to Wentao Shang
Actions
Copy link
 #2

Updated by Wentao Shang over 9 years ago

  • Status changed from New to Code review
  • % Done changed from 0 to 70
Actions
Copy link
 #3

Updated by Wentao Shang over 9 years ago

  • Status changed from Code review to Closed
  • % Done changed from 70 to 100
Actions
Copy link

Also available in: Atom PDF