Project

General

Profile

Task #2692

Import ndndump

Added by Junxiao Shi about 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Start date:
Due date:
% Done:

100%

Estimated time:
1.00 h

Description

Import ndndump to ndn-tools repository.

Changes should be minimized. Improvements will be separate issues.


Related issues

Related to ndn-tools - Feature #2670: wscript: build a subset of toolsClosedShock Jiang05/23/2015

Actions
Blocks ndn-tools - Feature #2855: README and manpages for ndndumpClosedJunxiao Shi

Actions
#1

Updated by Joao Pereira almost 6 years ago

Is this just as simple as:

1 - pick the source from github

2 - paste it in ndn-tools repo

3 - change waf files to compile it

#2

Updated by Junxiao Shi almost 6 years ago

  • Related to Feature #2670: wscript: build a subset of tools added
#3

Updated by Junxiao Shi almost 6 years ago

note-1 is mostly correct. The directory for ndndump is tools/dump.

The complication is: unlike all existing tools that depend on only ndn-cxx, ndndump has a dependency on libpcap.

As described in #2524 note-16 second option, libpcap dependency is required only if ndndump is enabled at configuration time.

Therefore, the dependency should be declared within ndndump, not globally. Top-level wscript needs to be tweaked to collect dependencies from wscripts in subdirectories.

#4

Updated by Junxiao Shi almost 6 years ago

  • Status changed from New to In Progress
  • Assignee set to Junxiao Shi
#5

Updated by Junxiao Shi almost 6 years ago

  • % Done changed from 0 to 50

http://gerrit.named-data.net/2053

ndndump contains a deprecated usage of Block::fromBuffer.

I want the import commit to be an exact copy (except wscript), so I'll fix the problem in ndndump repository before continuing in ndn-tools.

ndndump issue: https://github.com/named-data/ndndump/issues/2

#6

Updated by Junxiao Shi almost 6 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 50 to 100

http://gerrit.named-data.net/2053

ndndump depends on extra Boost libraries, but I didn't find a way to import boost.py waf-tool at tools/dump/wscript level, and had to do it at the top level.

#7

Updated by Junxiao Shi almost 6 years ago

#8

Updated by Junxiao Shi almost 6 years ago

  • Status changed from Code review to Closed
#9

Updated by Junxiao Shi almost 6 years ago

  • Status changed from Closed to In Progress
  • % Done changed from 100 to 80

I still need to change namespaces to conform to README-dev.md requirements in another commit.

#10

Updated by Junxiao Shi almost 6 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 80 to 100
#11

Updated by Junxiao Shi almost 6 years ago

  • Status changed from Code review to Closed

Also available in: Atom PDF