Task #2692: Import ndndump - ndn-tools - NDN project issue tracking system

Actions

Copy link

Task #2692

closed

Import ndndump

Added by Junxiao Shi over 9 years ago. Updated over 9 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Junxiao Shi

Start date:

Due date:

% Done:

100%

Estimated time:

1.00 h

Description

Import ndndump to ndn-tools repository.

Changes should be minimized. Improvements will be separate issues.

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Joao Pereira over 9 years ago

Is this just as simple as:

1 - pick the source from github

2 - paste it in ndn-tools repo

3 - change waf files to compile it

Actions

Copy link

Updated by Junxiao Shi over 9 years ago

Related to Feature #2670: wscript: build a subset of tools added

Actions

Copy link

Updated by Junxiao Shi over 9 years ago

note-1 is mostly correct. The directory for ndndump is tools/dump.

The complication is: unlike all existing tools that depend on only ndn-cxx, ndndump has a dependency on libpcap.

As described in #2524 note-16 second option, libpcap dependency is required only if ndndump is enabled at configuration time.

Therefore, the dependency should be declared within ndndump, not globally. Top-level wscript needs to be tweaked to collect dependencies from wscripts in subdirectories.

Actions

Copy link

Updated by Junxiao Shi over 9 years ago

Status changed from New to In Progress
Assignee set to Junxiao Shi

Actions

Copy link

Updated by Junxiao Shi over 9 years ago

% Done changed from 0 to 50

http://gerrit.named-data.net/2053

ndndump contains a deprecated usage of Block::fromBuffer.

I want the import commit to be an exact copy (except wscript), so I'll fix the problem in ndndump repository before continuing in ndn-tools.

ndndump issue: https://github.com/named-data/ndndump/issues/2

Actions

Copy link

Updated by Junxiao Shi over 9 years ago

Status changed from In Progress to Code review
% Done changed from 50 to 100

http://gerrit.named-data.net/2053

ndndump depends on extra Boost libraries, but I didn't find a way to import boost.py waf-tool at tools/dump/wscript level, and had to do it at the top level.

Actions

Copy link