Project

General

Profile

Actions

Feature #2749

closed

Derive version from git repository and elsewhere

Added by Junxiao Shi over 9 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Start date:
Due date:
% Done:

100%

Estimated time:
1.50 h

Description

Derive version string from:

  1. git describe
  2. VERSION file
  3. constant in build script

The procedure should be implemented in Python as part of wscript.
The derived version string should be used to generate core/version.cpp, and also written into VERSION file.


Related issues 1 (0 open1 closed)

Blocked by ndn-tools - Feature #2671: Print version numberClosedJunxiao Shi

Actions
Actions #1

Updated by Junxiao Shi over 9 years ago

Actions #2

Updated by Junxiao Shi almost 8 years ago

  • Assignee set to Eric Newberry
Actions #3

Updated by Eric Newberry almost 8 years ago

Is a similar feature already implemented in ndn-cxx and NFD?

Actions #4

Updated by Junxiao Shi almost 8 years ago

Answer to note-3:

Yes, both NFD and ndn-cxx wscript already have this feature.
However, I dislike the implementation in NFD. See discussion in #2671.

Actions #5

Updated by Eric Newberry almost 8 years ago

Is the version string derived from all three sources or are they in an order of precedence (if can't determine version from git describe, try VERSION file)?

Actions #6

Updated by Alex Afanasyev almost 8 years ago

These order:

  • git describe
  • version file
  • constant

version file is autogenerated using git describe and should not exist in the repository (created for standalone .tar.gz archives). constant in wscript is used as a backup if something went wrong.

Actions #7

Updated by Eric Newberry almost 8 years ago

  • Status changed from New to In Progress
Actions #8

Updated by Eric Newberry almost 8 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 0 to 100
Actions #9

Updated by Junxiao Shi almost 8 years ago

  • Status changed from Code review to Closed
Actions

Also available in: Atom PDF