Project

General

Profile

Actions

Task #2788

closed

Lsa type should be argument for base class LSA constructor

Added by Vince Lehman over 9 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Low
Target version:
Start date:
05/05/2015
Due date:
% Done:

100%

Estimated time:

Description

Currently, the constructors for the LSA implementations take a string for the LS type as a constructor parameter.

Instead, this parameter should be removed from their constructor and should be passed when initializing the base class.

  • This task should remove the Lsa::setLsType() method, as there is no reason to change the LSA type after construction.
  • The member variable Lsa.m_lsType should be const as it should not be changed after construction.
  • The Lsa::Lsa() constructor should take an LSA type as a parameter and assign it to m_lsType.
  • All derived classes should pass their TYPE_STRING to the LSA constructor in their initialization list
  • Constructors for derived classes should not take the LSA type as a parameter. The LSA type for an LSA is a strict value and should not be modifiable by the API.
Actions #1

Updated by Vince Lehman over 9 years ago

  • Target version set to v0.3.0
Actions #2

Updated by Vince Lehman over 9 years ago

  • Assignee set to Muktadir Chowdhury
Actions #3

Updated by Vince Lehman almost 9 years ago

  • Assignee changed from Muktadir Chowdhury to Ashlesh Gawande
Actions #4

Updated by Vince Lehman almost 9 years ago

  • Description updated (diff)
Actions #5

Updated by Ashlesh Gawande almost 9 years ago

  • Status changed from New to Code review
Actions #6

Updated by Ashlesh Gawande over 8 years ago

  • Status changed from Code review to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF