Actions
Task #2788
closedLsa type should be argument for base class LSA constructor
Start date:
05/05/2015
Due date:
% Done:
100%
Estimated time:
Description
Currently, the constructors for the LSA implementations take a string for the LS type as a constructor parameter.
Instead, this parameter should be removed from their constructor and should be passed when initializing the base class.
- This task should remove the Lsa::setLsType() method, as there is no reason to change the LSA type after construction.
- The member variable Lsa.m_lsType should be const as it should not be changed after construction.
- The Lsa::Lsa() constructor should take an LSA type as a parameter and assign it to m_lsType.
- All derived classes should pass their TYPE_STRING to the LSA constructor in their initialization list
- Constructors for derived classes should not take the LSA type as a parameter. The LSA type for an LSA is a strict value and should not be modifiable by the API.
Updated by Vince Lehman almost 9 years ago
- Assignee changed from Muktadir Chowdhury to Ashlesh Gawande
Updated by Ashlesh Gawande almost 9 years ago
- Status changed from New to Code review
Updated by Ashlesh Gawande over 8 years ago
- Status changed from Code review to Closed
- % Done changed from 0 to 100
Actions