NFD » ndn-tools

The only public function in Ping is void run()? What can really be tested?

Reply to note-6:

PingServer can be individually tested by feeding Interests into it through a DummyClientFace.

Ping and PingServer can be tested together by attaching them onto two paired DummyClientFaces.
The pairing mechanism can be used to simulate packet losses between Ping and PingServer.

Is there a way to pause the thread in the unit tests for ndntools? I need to do this to wait for timeouts and the like. I see something similar in the ndn-cxx tests (UnitTestTimeFixture), but not in ndntools.

Also, wouldn't the server and client have to be run in separate threads for the integrated tests, as their run() functions are blocking?

Reply to note-7:

UnitTestTimeFixture can copied to ndn-tools if necessary.

Reply to note-8:

No, I didn't expect this test suite to require multi-threading.

It seems that a bit of additional refactoring is necessary to support unit testing (and also ndnSIM integration):

• Ping and PingServer hook work (eg. express Interest on Face, register prefix on Face, schedule events with Scheduler) onto the io_service of the supplied Face in a start method.
• Ping::run() and PingServer::run() call this->start() and then io.run().
• The test case can invoke .start() on both Ping and PingServer, followed by io.run() or io.poll(), to execute both Ping and PingServer on the same thread.

Junxiao Shi wrote:

It seems that a bit of additional refactoring is necessary to support unit testing (and also ndnSIM integration):

• Ping and PingServer hook work (eg. express Interest on Face, register prefix on Face, schedule events with Scheduler) onto the io_service of the supplied Face in a start method.
• Ping::run() and PingServer::run() call this->start() and then io.run().
• The test case can invoke .start() on both Ping and PingServer, followed by io.run() or io.poll(), to execute both Ping and PingServer on the same thread.

I'll work on the refactoring. Another redmine issue will probably be necessary for it.

I refactored Ping and PingServer. Ping and PingServer are on different DummyClientFaces that are on the same io_service. However, PingServer is not receiving Interests from Ping. Is there a special method that has to be used to work with DummyClientFace?

Answer to note-13:

Two DummyClientFaces attached to the same io_service won't magically communicate with each other.

They need to be glued together. See ndn::ndns::tests::QueryControllerFixture for an example.