Project

General

Profile

Actions
Copy link

Bug #2854

closed

poke: Face::put WARNING

Added by Junxiao Shi almost 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Junxiao Shi
Start date:
06/05/2015
Due date:
% Done:

100%

Estimated time:

Description

Steps to reproduce:

  1. echo 'HELLO WORLD' | ndnpoke ndn:/localhost/demo/hello
  2. ndnpeek -p ndn:/localhost/demo/hello

Actual: ndnpoke prints Face::put WARNING: the supplied Data should be created using make_shared<Data>()

Expected: no such error

Related issues 1 (0 open — 1 closed)

Related to ndn-cxx - Task #1775: Change Face::put to recommend/require shared_ptr<Data>ClosedAlex Afanasyev07/18/2014

Actions
Actions
Copy link
 #1

Updated by Junxiao Shi almost 9 years ago

  • Related to Task #1775: Change Face::put to recommend/require shared_ptr<Data> added
Actions
Copy link
 #2

Updated by Alex Afanasyev almost 9 years ago

Should we reconsider #1775 and remove the warning? In theory, copying data packet is not a big deal...

Actions
Copy link
 #3

Updated by Junxiao Shi almost 9 years ago

note-2 question is out of scope of this issue. Please open a separate issue for discussion.

Actions
Copy link
 #4

Updated by Junxiao Shi almost 9 years ago

  • Status changed from New to In Progress
  • Assignee set to Junxiao Shi
Actions
Copy link
 #5

Updated by Junxiao Shi almost 9 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 0 to 100
Actions
Copy link
 #6

Updated by Junxiao Shi almost 9 years ago

  • Status changed from Code review to Closed
Actions
Copy link

Also available in: Atom PDF