Feature #2898
closed
Make remove operation in PibImpl as deep remove
Added by Yingdi Yu over 9 years ago.
Updated over 9 years ago.
Description
Current spec of PibImpl does not require removeXXX to be deep removal, that is removal of an identity does not remove the related keys/cert. removal of a key does not remove a related cert.
We should explicit require PibImpl implementation to remove all related entities.
- Tracker changed from Task to Feature
- Status changed from New to Code review
- % Done changed from 0 to 80
commit:7d1f4572e81479f7f1911d46693e68f1bcf0bdae makes deep remove the responsibility of PibImpl, which adds complexity every PibImpl subclass.
Why not keep PibImpl simple and implement this feature in Pib?
Junxiao Shi wrote:
commit:7d1f4572e81479f7f1911d46693e68f1bcf0bdae makes deep remove the responsibility of PibImpl, which adds complexity every PibImpl subclass.
Why not keep PibImpl simple and implement this feature in Pib?
The reason is similar to http://redmine.named-data.net/issues/2896#note-3
Because PibImpl is expected to be implemented on a database. It would be more efficient to do this with DB support. Doing it in Pib may involve many function calls.
commit:726c07cb049114f8bd21684127797d969ee17c2d implements deep remove with a foreign key.
This does not increase complexity.
Therefore, I agree with note-3.
- Status changed from Code review to Closed
- % Done changed from 80 to 100
Also available in: Atom
PDF
Updated by 
Updated by