Project

General

Profile

Actions
Copy link

Task #2962

closed

Implement a NameLsa::isEqualContent() method

Added by Muktadir Chowdhury almost 9 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Nicholas Gordon
Target version:
v0.4.0
Start date:
06/25/2015
Due date:
05/26/2017
% Done:

80%

Estimated time:

Description

There is a method, which compares two LSA content, for each of the Adjacency and Coordinate LSA. Name Lsa should also have a method like that.

Actions
Copy link
 #1

Updated by Nicholas Gordon almost 7 years ago

  • Status changed from New to In Progress
  • Assignee set to Nicholas Gordon
  • Target version set to v0.4.0
Actions
Copy link
 #2

Updated by Nicholas Gordon almost 7 years ago

  • Due date set to 05/26/2017
Actions
Copy link
 #3

Updated by Nicholas Gordon almost 7 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 0 to 80

I also feel that the LSAs should get operator==. That's the idiomatic way to compare objects in C++, and since now have a way to compare each type, it would be only a small job.

Actions
Copy link
 #4

Updated by Junxiao Shi almost 7 years ago

I also feel that the LSAs should get operator==.

If all fields are being compared, operator== is better.

Actions
Copy link
 #5

Updated by Nicholas Gordon almost 7 years ago

  • Status changed from Code review to Closed

This has been merged. Work continues on the operator== patch.

Actions
Copy link

Also available in: Atom PDF