NFD » ndn-cxx

http://gerrit.named-data.net/2402

There is a dispute on where to upload this change, master or feature-keychain:

Yingdi Yu 09-04 11:50
I prefer to put this commit into feature-keychain branch, instead of master branch.

Spyros Mastorakis 09-04 12:04
Why so? It does not break anything and it is backward compatible.

Yingdi Yu 09-04 12:58
Because feature-keychain introduces more code that use EcdsaKeyParams, so you need to add one commit to fix that anyway. It is up to you, either you make two commits, one in master and one in feature-keychain, or you make one commit in feature-keycahin.

Spyros Mastorakis 09-04 13:00
I see. I think that making two commits (one for master and one for the feature-keychain branch) makes more sense. I will proceed like this.

Alex Afanasyev 09-04 17:21
i don't see how making two commits makes sense. The branch code will be merged at some point and the same change will be in multiple places.
If it goes to master, feature branch needs to be rebased

Spyros Mastorakis 09-04 18:07
This commit is ready for master. Decide what you want to merge and where and let me know.

To keep backward compatibility, we still need to keep EcdsaKeyParams using typedef, but mark it as deprecated.

In note-5 we decided that this patch goes to feature-keychain branch which already contains many breaking changes.
Is it still necessary to have a deprecated EcdsaKeyParams alias?