Project

General

Profile

Actions

Feature #3146

closed

Face::getTransport method

Added by Alex Afanasyev over 8 years ago. Updated about 8 years ago.

Status:
Closed
Priority:
Low
Category:
Base
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
1.50 h

Description

In several instances (DummyFace, InternalClientFace), it is necessary to access the underlying Transport class. The current workaround includes creating helper functions. With Face::getTransport, helper functions no longer be necessary.


Related issues 1 (0 open1 closed)

Blocks NFD - Bug #3383: Deprecated makeDummyClientFace usageClosedJunxiao Shi12/31/2015

Actions
Actions #1

Updated by Junxiao Shi over 8 years ago

  • Category set to Base

Both DummyFace and InternalClientFace are subclasses of ndn::Face, so getTransport should be declared as protected.

Actions #2

Updated by Junxiao Shi over 8 years ago

  • Subject changed from Add Face::getTransport method to Face::getTransport method
  • Estimated time set to 1.50 h
Actions #3

Updated by Alex Afanasyev over 8 years ago

  • Target version set to v0.5
Actions #4

Updated by Alex Afanasyev about 8 years ago

  • Status changed from New to In Progress
  • Assignee set to Alex Afanasyev
Actions #5

Updated by Junxiao Shi about 8 years ago

After having Face::getTransport, makeDummyClientFace should be deprecated (with Doxygen only for now) and make_shared<DummyClientFace> should work.

Actions #6

Updated by Junxiao Shi about 8 years ago

Is it necessary for a caller of Face::getTransport to obtain shared ownership of Transport?
If there isn't such a use case, it's better to return a mutable reference, so that we could use unique_ptr<Transport> in the future without affecting this API.

Actions #7

Updated by Junxiao Shi about 8 years ago

  • Blocks Bug #3383: Deprecated makeDummyClientFace usage added
Actions #8

Updated by Alex Afanasyev about 8 years ago

  • Status changed from In Progress to Closed
  • Target version changed from v0.5 to v0.4
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF