Project

General

Profile

Actions

Bug #3235

closed

regex.t.cpp -Wkeyword-macro

Added by Junxiao Shi over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Utils
Target version:
Start date:
10/03/2015
Due date:
% Done:

100%

Estimated time:

Description

Build error -Wkeyword-macro in tests/unit-tests/util/regex.t.cpp.

  • OSX 10.10
  • Apple LLVM version 7.0.0 (clang-700.0.72)
  • Boost 1.58.0 from Homebrew
  • ndn-cxx:commit:d06ea05070dd2e49cc8c0eedae46812f4247949e
  • ./waf configure --with-tests --debug --without-pch --without-osx-keychain
[ 37/247] Compiling tests/unit-tests/util/regex.t.cpp
In file included from ../tests/unit-tests/util/regex.t.cpp:25:
In file included from /Users/shijunxiao/code/ndn-cxx/src/util/regex/regex-component-matcher.hpp:27:
In file included from /usr/local/include/boost/regex.hpp:31:
In file included from /usr/local/include/boost/regex/v4/regex.hpp:97:
/usr/local/include/boost/regex/v4/instances.hpp:124:17: error: keyword is hidden by macro definition [-Werror,-Wkeyword-macro]
#        define template __extension__ extern template
                ^
In file included from ../tests/unit-tests/util/regex.t.cpp:25:
In file included from /Users/shijunxiao/code/ndn-cxx/src/util/regex/regex-component-matcher.hpp:27:
In file included from /usr/local/include/boost/regex.hpp:31:
In file included from /usr/local/include/boost/regex/v4/regex.hpp:108:
/usr/local/include/boost/regex/v4/instances.hpp:124:17: error: keyword is hidden by macro definition [-Werror,-Wkeyword-macro]
#        define template __extension__ extern template
                ^
2 errors generated.

Waf: Leaving directory `/Users/shijunxiao/code/ndn-cxx/build'
Build failed
 -> task in 'unit-test-objects' failed (exit status 1): 
    {task 4524721360: cxx regex.t.cpp -> regex.t.cpp.3.o}
['/usr/bin/clang++', '-pedantic', '-Wall', '-O0', '-g3', '-Werror', '-fcolor-diagnostics', '-Wno-unused-local-typedef', '-Wno-error=unneeded-internal-declaration', '-Wno-error=deprecated-register', '-std=c++11', '-stdlib=libc++', '-I/Users/shijunxiao/code/ndn-cxx/build/tests', '-I/Users/shijunxiao/code/ndn-cxx/tests', '-I/Users/shijunxiao/code/ndn-cxx/build/src', '-I/Users/shijunxiao/code/ndn-cxx/src', '-I/usr/local/include', '-D_DEBUG', '-DUNIT_TEST_CONFIG_PATH="build/tmp-files/"', '../tests/unit-tests/util/regex.t.cpp', '-c', '-o', '/Users/shijunxiao/code/ndn-cxx/build/tests/unit-tests/util/regex.t.cpp.3.o']
Actions #1

Updated by Junxiao Shi over 8 years ago

  • Tracker changed from Task to Bug
Actions #2

Updated by Davide Pesavento over 8 years ago

Why isn't this triggered in CI?

Actions #3

Updated by Junxiao Shi over 8 years ago

  • Status changed from New to In Progress
  • Assignee set to Junxiao Shi
  • Target version set to v0.4

Answer to note-2:

Jenkins probably doesn't have the same compiler+Boost combination as the machine with this problem.

Actions #4

Updated by Junxiao Shi over 8 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 0 to 100

ndn-cxx http://gerrit.named-data.net/2490

NFD has similar error in tools/nfdc.cpp http://gerrit.named-data.net/2491

Actions #5

Updated by Junxiao Shi over 8 years ago

ndn-tools has similar error in ndndump http://gerrit.named-data.net/2492

Actions #6

Updated by Davide Pesavento over 8 years ago

Junxiao Shi wrote:

Jenkins probably doesn't have the same compiler+Boost combination as the machine with this problem.

Right. This exposes a potential weakness in our current testing. AFAIU we officially support boost >= 1.48 on OSX, but only a small subset of boost versions (maybe only one?) is actually tested by the CI.

Actions #7

Updated by Junxiao Shi over 8 years ago

  • Status changed from Code review to Closed
Actions

Also available in: Atom PDF