Project

General

Profile

Actions
Copy link

Task #3377

closed

FaceManager: test suite improvement

Added by Junxiao Shi about 9 years ago. Updated about 2 months ago.

Status:
Closed
Priority:
Low
Assignee:
Davide Pesavento
Category:
Management
Target version:
25.next
Start date:
Due date:
% Done:

100%

Estimated time:
7.50 h
Tags:
unit-tests

Description

Improve FaceManager test suite with coverage for these functions and situations:

  • faces/create command with malformed FaceUri DONE
  • faces/create command with non-canonical FaceUri DONE
  • faces/create command with a FaceUri of unsupported scheme DONE
  • face query operation with LocalUri condition DONE
  • face query operation with RemoteUri condition DONE
  • face query operation with FacePersistency condition DONE
  • face query operation with LinkType condition DONE

Additionally, the test suite should manage a NetworkMonitor instance, and stop using the deprecated FaceSystem(FaceTable&) constructor before deleting that constructor. DONE

Related issues 1 (1 open — 0 closed)

Related to NFD - Task #3325: Improve FaceDataset and GeneralStatusDataset testsIn Progress

Actions
Actions
Copy link
 #1

Updated by Davide Pesavento about 8 years ago

  • Description updated (diff)
  • Target version changed from v0.5 to v0.6
Actions
Copy link
 #2

Updated by Junxiao Shi almost 8 years ago

  • Status changed from New to In Progress
  • Assignee set to Junxiao Shi
  • % Done changed from 0 to 40

https://gerrit.named-data.net/3842 faces/create bad FaceUri cases

Actions
Copy link
 #3

Updated by Junxiao Shi over 7 years ago

  • Assignee deleted (Junxiao Shi)

I don't plan to work on face query operations.

Actions
Copy link
 #4

Updated by Davide Pesavento over 7 years ago

  • Related to Task #3325: Improve FaceDataset and GeneralStatusDataset tests added
Actions
Copy link
 #5

Updated by Junxiao Shi over 7 years ago

  • Description updated (diff)
  • Estimated time changed from 6.00 h to 7.50 h
Actions
Copy link
 #6

Updated by Davide Pesavento over 7 years ago

  • Description updated (diff)
  • Target version deleted (v0.6)
Actions
Copy link
 #7

Updated by Davide Pesavento over 7 years ago

  • % Done changed from 40 to 60

https://gerrit.named-data.net/4211 removes the deprecated FaceSystem constructor.

Actions
Copy link
 #8

Updated by Davide Pesavento over 7 years ago

  • Description updated (diff)
  • Priority changed from Normal to Low
Actions
Copy link
 #9

Updated by Davide Pesavento over 6 years ago

  • Status changed from In Progress to Feedback
Actions
Copy link
 #10

Updated by Davide Pesavento over 6 years ago

  • Tags set to UnitTests
Actions
Copy link
 #11

Updated by Davide Pesavento over 2 years ago

  • Status changed from Feedback to In Progress
Actions
Copy link
 #12

Updated by Davide Pesavento about 2 months ago

  • Assignee set to Davide Pesavento
  • Target version set to 25.next
Actions
Copy link
 #13

Updated by Davide Pesavento about 2 months ago

  • Description updated (diff)
  • Status changed from In Progress to Code review
  • % Done changed from 60 to 100

https://gerrit.named-data.net/c/NFD/+/7642
This change expands testing of the query operation to cover the missing filter predicates, including an empty predicate (matching all faces) and an "impossible" predicate (matching zero faces).

Actions
Copy link
 #14

Updated by Davide Pesavento about 2 months ago

  • Status changed from Code review to Closed
Actions
Copy link

Also available in: Atom PDF