Project

General

Profile

Actions

Bug #3388

closed

WebSocketTransport: inaccurate LocalUri

Added by Junxiao Shi almost 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Faces
Target version:
Start date:
01/05/2016
Due date:
% Done:

0%

Estimated time:
1.50 h

Description

Steps to reproduce:

  1. Connect to NFD over WebSocket.
  2. Execute nfd-status -f.

Expected: LocalUri for WebSocket face contains IP address.

Actual: LocalUri for WebSocket face looks like ws://[::]:9696 and does not contain IP address.

Actions #1

Updated by Davide Pesavento almost 9 years ago

Unit testing didn't catch this bug because TestWebSocketTransport/StaticProperties only checks an IPv4 loopback address. Can you confirm that using IPv4 yields the expected result?

As part of this issue, TestWebSocketTransport needs to be extended to test IPv6 endpoints as well.

Actions #2

Updated by Junxiao Shi almost 9 years ago

Can you confirm that using IPv4 yields the expected result?

Either IPv4 and IPv6 connection shows ws://[::]:9696 as LocalUri.

I'm okay with showing ws://[::ffff:192.0.2.128]:9696 for IPv4 connection.

Actions #3

Updated by Davide Pesavento almost 9 years ago

Sorry I wasn't clear. In your test you tried connecting via IPv4, but NFD was still using the IPv6 WebSocketChannel (this is because the v6 channel is really v4+v6, since websocketpp doesn't allow creating v6-only servers). What I meant was: disable the v6 websocket listener in NFD and try again (via IPv4 obviously).

Actions #4

Updated by Junxiao Shi almost 9 years ago

  • Status changed from New to Closed

The issue is gone after updating to NFD 0.4.0. Both IPv4 and IPv6 work correctly.

The report was based on NFD 0.4.0-beta2.

Actions

Also available in: Atom PDF