NFD

Review of Face section at nfd-docs:commit:f936e1c8fa281ba395972a861a4ad3e90c797307.

"Generic Link Service" section:

• "Interests, Data, and Nack are now encapsulated in an LpPacket" implies one LpPacket can contain multiple network layer packets, which is permissible by protocol but not supported in GenericLinkService.
• IncomingFaceId field can be attached to any LpPacket, not just Interest and Data.
• The detailed discussion about fragmentation and reassembly should go into a subsection.
• "NDNLPv2 uses indexed fragmentation" is inaccurate. NDNLPv2 supports indexed fragmentation among other potential fragmentation schemes, while GenericLinkService uses indexed fragmentation.
• The timeout mechanism in reassembler should be discussed.
• How does the reassembler deal with multiple senders on a multi-access link?

Changes related to note 5 have been pushed.

Review of Face section at nfd-docs:commit:e5421bb278f4fa6c5ed628b584fe64697ce7f9e9.

"Generic Link Service" section:

• "Transport" and "Link Service" should not be capitalized everywhere, if not referring to the base class.
• "Generic Link Service" is fine.

"What services are enabled depends upon the type of Transport" table:

• Rows should be ordered same as "Transport" subsections.
• NextHopFaceId-CachePolicy-IncomingFaceId should be categorized as a single "local fields" feature.
• "local fields" can be enabled for UnixStreamTransport and TcpTransport on loopback address (more precisely, any transport with Scope=local) through a management command. In this table or the accompanying text, reference "Face Manager" section. In "Face Manager" section, update the text about enableLocalControl command to reflect what it does in NFD 0.4.0.
• Fragmentation is necessary for unicast UDP and multicast UDP transports, because they have limited MTU.

"Packet Fragmentation and Reassembly in the Generic Link Service" section:

• This should be a subsection nested under "Generic Link Service" section.
• At the first occurrence of "indexed fragmentation", reference the introduction of this feature in NDNLP section.
• Before going into "The fragmenter returns a vector", introduce that the sender has a fragmenter and the receiver has a reassembler.
• Explain what is "remote endpoint id". It should go into "Face - internal structure" paragraph, and describe the send/receive APIs between LinkService and Transport. Then the reassembler description can reference that.

Review of Face section at nfd-docs:commit:8c2ceec3492e9f7105569cd0e7dbb036885992a1.

"What services are enabled depends upon the type of Transport" table:

• In "Face Manager" section, update the text about enableLocalControl command to reflect what it does in NFD 0.4.0.

"Packet Fragmentation and Reassembly in the Generic Link Service" paragraph:

• Add a section reference to "(see Face - internal structure)".

"Developing a New Link Service" section:

• "sending outgoing and decoding incoming Interest .." is asymmetric. Change "sending" to "encoding".
• Encoding outgoing packets and decoding incoming packets are the only required tasks of a link service.
• "assigning Sequence numbers to packets" is not a required task for every link service. It's only required by NDNLPv2.
• "encoding and decoding local fields" is not a required task for every link service.

Revisions based upon note 9 have been pushed.

Junxiao Shi wrote:

• In "Face Manager" section, update the text about enableLocalControl command to reflect what it does in NFD 0.4.0.

I updated this section in the last revision (note 8). What exactly should be changed here?

Reply to note-11:

This refers to "Management - Managers - Face Manager" section.
It still contains "LocalControlHeader" which is deprecated.

Revisions based upon note 12 have been pushed.