Feature #3653
closed
Controller: response validation
100%
Description
Use a Validator to validate response Data to ControlCommand and StatusDataset, and fail the operation if validation fails.
Controller should accept a Validator& parameter.
The default shall be an internal ValidatorNull instance for backwards compatibility.
Updated by Junxiao Shi over 8 years ago
- Blocked by Feature #3329: Controller: client for StatusDataset added
Updated by Junxiao Shi over 8 years ago
- Status changed from New to In Progress
- Assignee set to Junxiao Shi
- Target version set to v0.5
I'll work on this issue in two commits:
- accept
Validator¶meter, and call validator for StatusDataset; this satisfies immediate needs for #3658 - call validator for ControlCommand
Updated by Junxiao Shi over 8 years ago
- % Done changed from 0 to 50
https://gerrit.named-data.net/2914 accepts Validator on Controller constructor, and adds a test case for StatusDataset response validation.
Updated by Junxiao Shi over 8 years ago
https://gerrit.named-data.net/2914 patchset6 abstracts the validator used in test suite as DummyValidator so it can be reused in other test suites.
Updated by Junxiao Shi over 8 years ago
- % Done changed from 50 to 60
Before I could add validation to ControlCommand functionality, I notice there's inconsistency between how empty failure callbacks are handled.
https://gerrit.named-data.net/2943 fixes the problem, and also reorders existing test cases.
Updated by Junxiao Shi over 8 years ago
- Status changed from In Progress to Code review
- % Done changed from 60 to 100
https://gerrit.named-data.net/3044 implements ControlCommand response validation.
Updated by Junxiao Shi over 8 years ago
- Status changed from Code review to Closed