Project

General

Profile

Actions
Copy link

Bug #3683

closed

dump: grammar error in error message

Added by Junxiao Shi over 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Junxiao Shi
Start date:
07/24/2016
Due date:
% Done:

100%

Estimated time:
1.00 h

Description

Steps to reproduce:

  1. ndndump -r file-does-not-exist

Actual:

terminate called after throwing an instance of 'ndn::tools::Ndndump::Error'
  what():  Cannot file file-does-not-exist for reading (file-does-not-exist: No such file or directory)
Aborted

where "Cannot file" is a not a valid English phrase.

Expected: The error message is free of grammar errors.

Actions
Copy link
 #1

Updated by Junxiao Shi over 9 years ago

  • Status changed from New to In Progress
  • Assignee set to Junxiao Shi
Actions
Copy link
 #2

Updated by Junxiao Shi over 9 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 0 to 100

https://gerrit.named-data.net/2974 corrects code style in tools/dump/ in preparation for the fix.

https://gerrit.named-data.net/2975 has the fix.

I'm also adding a catch in main function to suppress terminate called after throwing an instance of 'ndn::tools::Ndndump::Error' and display just the error message.
I intentionally do not use nfd::getExtendedErrorInfo because the program is simple enough so that showing where an exception is thrown isn't that useful.

Actions
Copy link
 #3

Updated by Junxiao Shi over 9 years ago

  • Status changed from Code review to Closed
Actions
Copy link
 #4

Updated by Junxiao Shi almost 9 years ago

  • Status changed from Closed to Feedback

There is misbalance of parenthesis in this error message:

BOOST_THROW_EXCEPTION(Error("Unsupported pcap format (" + to_string(m_dataLinkType)));
Actions
Copy link
 #5

Updated by Junxiao Shi almost 9 years ago

  • Status changed from Feedback to Code review

note-4 issue is fixed in https://gerrit.named-data.net/3345.

Actions
Copy link
 #6

Updated by Junxiao Shi almost 9 years ago

  • Status changed from Code review to Closed
Actions
Copy link

Also available in: Atom PDF