NLSR

Nick, below are some suggested additions. Did you have any source code files in particular you wanted me to look at? I found interests being scheduled, sent, and received, but did not find the reply you were referencing.

nlsr.cpp

• (lines 308 and 313) should log certificate retrieval failures

lsdb.cpp

• (line 197) lsdb::installNameLsa
• * (Line 260) removes names not being advertised anymore; not sure where the method is to check if debug message is located there. Only see (line 307) removeNameLSA() not (line 269) removeName() which is pointed to by ChkName
• (line 108) lsdb::afterFetchLsa()
• * Maybe mention something in first else if block about the seqNo being updated
• (line 575) scheduleAdjLsaBuild()
• * (Line 580) doesn’t say anything when an adjLsa is not built due to Hyperbolic state
• (Line 845, 888, 941) edit debug: “form” to “from”. It looks like a typo.

hello-protocol.cpp

• (line 53) sendScheduledInterest()
• * Log that it is now sending the scheduled interest
• * Display what interest is being sent. It’s located in the if block.
• (line 89) processInterest()
• * (line 95) needs to log that the interestName is not an INFO_COMPONENT
• * Also maybe we should add logs showing a neighbor has become active again or a new one has been created. Should we place at the end of this method (line 131) or at the end of registerPrefixes() (line 128)?
• (line 134) processInterestTimedOut()
• * Needs to show that a neighbor has become inactive

Those are fine suggestions. You should look particularly at Lsdb::putLsaData and the its callers and callees. You can make this a little easier by doing this:

1. Install doxygen (via package manager, whatever)
2. Edit docs/doxygen.conf and change EXTRACT_PRIVATE = NO to EXTRACT_PRIVATE = YES (I have it on line 405)
3. Issue ./waf configure and then ./waf doxygen
4. Open build/docs/doxygen/index.html in your web browser, and browse the API there. That will give you a better caller/callee graph.

Note: You can reach this documentation at http://named-data.net/doc/NLSR/current/doxygen/annotated.html also, but that link doesn't extract private methods. You want this because it gives you a better map of the code structure.