Bug #4058
closed
nfdc input and output format changes cause integration tests to fail
100%
Description
Changes to the arguments and output format of the nfdc command cause the following integration test scenarios to fail:
- test_route_expiration
- test_nexthopfaceid
- test_route_inheritance
All calls to nfdc and nfd-status using deprecated syntax should also be corrected.
Files
Updated by Eric Newberry almost 7 years ago
- Status changed from New to In Progress
Updated by Junxiao Shi almost 7 years ago
Given nfdc refactoring is (almost) complete, all usages of deprecated syntax should be replaced.
Updated by Eric Newberry almost 7 years ago
Junxiao Shi wrote:
Given
nfdcrefactoring is (almost) complete, all usages of deprecated syntax should be replaced.
Agreed. I'll update the issue description to include this.
Updated by Eric Newberry almost 7 years ago
It looks like I can't change the issue description. @Junxiao could you update it to include the content of notes 2 and 3?
Updated by Eric Newberry almost 7 years ago
- Status changed from In Progress to Code review
- % Done changed from 0 to 90
A commit has been pushed to Gerrit for updating all syntax of nfdc and changing calls to nfd-status to their nfdc equivalent, with the exception of test_nfdc.
Updated by Junxiao Shi almost 7 years ago
- File 20170422235659.tgz 20170422235659.tgz added
- Target version set to v0.6
Updated by Eric Newberry almost 7 years ago
For test_nfdc, I propose restructuring the test cases from the following:
nfdc create/add-nexthop/destroynfdc add-nexthop/remove-nexthopnfdc register/unregister
to the following:
nfdc face create/route add/route remove/face destroy(and verify the RIB withnfdc rib) - since direct adds to the FIB are no longer possible throughnfdc, merge all three of the existing test casesnfdc strategy set/strategy show/strategy unset- new test case
Updated by Eric Newberry almost 7 years ago
I was able to merge the two proposed test cases. Code will be posted for review shortly.
Updated by Eric Newberry almost 7 years ago
- % Done changed from 90 to 100
Changes to test_nfdc have been pushed to Gerrit for review.
Updated by Eric Newberry almost 7 years ago
- Related to Bug #3933: Nack test incorrect counting of Nacks added
Updated by Junxiao Shi almost 7 years ago
- Status changed from Code review to Closed
Updated by Eric Newberry almost 7 years ago
There are still some uses of the deprecated nfdc input and output format in test_nack, but they will be addressed in the commit for #3933.