Project

General

Profile

Actions

Bug #4058

closed

nfdc input and output format changes cause integration tests to fail

Added by Eric Newberry over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Integration Tests
Target version:
Start date:
04/19/2017
Due date:
% Done:

100%

Estimated time:

Description

Changes to the arguments and output format of the nfdc command cause the following integration test scenarios to fail:

  • test_route_expiration
  • test_nexthopfaceid
  • test_route_inheritance

All calls to nfdc and nfd-status using deprecated syntax should also be corrected.


Files

20170422235659.tgz (842 KB) 20170422235659.tgz integ 3856,5 Junxiao Shi, 04/22/2017 08:13 PM

Related issues 1 (0 open1 closed)

Related to NFD - Bug #3933: Nack test incorrect counting of NacksClosedEric Newberry

Actions
Actions #1

Updated by Eric Newberry over 7 years ago

  • Status changed from New to In Progress
Actions #2

Updated by Junxiao Shi over 7 years ago

Given nfdc refactoring is (almost) complete, all usages of deprecated syntax should be replaced.

Actions #3

Updated by Eric Newberry over 7 years ago

Junxiao Shi wrote:

Given nfdc refactoring is (almost) complete, all usages of deprecated syntax should be replaced.

Agreed. I'll update the issue description to include this.

Actions #4

Updated by Eric Newberry over 7 years ago

It looks like I can't change the issue description. @Junxiao could you update it to include the content of notes 2 and 3?

Actions #5

Updated by Eric Newberry over 7 years ago

  • Description updated (diff)
Actions #6

Updated by Eric Newberry over 7 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 0 to 90

A commit has been pushed to Gerrit for updating all syntax of nfdc and changing calls to nfd-status to their nfdc equivalent, with the exception of test_nfdc.

Actions #7

Updated by Junxiao Shi over 7 years ago

Actions #8

Updated by Eric Newberry over 7 years ago

For test_nfdc, I propose restructuring the test cases from the following:

  • nfdc create / add-nexthop / destroy
  • nfdc add-nexthop / remove-nexthop
  • nfdc register / unregister

to the following:

  • nfdc face create / route add / route remove / face destroy (and verify the RIB with nfdc rib) - since direct adds to the FIB are no longer possible through nfdc, merge all three of the existing test cases
  • nfdc strategy set / strategy show / strategy unset - new test case
Actions #9

Updated by Eric Newberry over 7 years ago

I was able to merge the two proposed test cases. Code will be posted for review shortly.

Actions #10

Updated by Eric Newberry over 7 years ago

  • % Done changed from 90 to 100

Changes to test_nfdc have been pushed to Gerrit for review.

Actions #11

Updated by Eric Newberry over 7 years ago

  • Related to Bug #3933: Nack test incorrect counting of Nacks added
Actions #12

Updated by Junxiao Shi over 7 years ago

  • Status changed from Code review to Closed
Actions #13

Updated by Eric Newberry over 7 years ago

There are still some uses of the deprecated nfdc input and output format in test_nack, but they will be addressed in the commit for #3933.

Actions

Also available in: Atom PDF