Project

General

Profile

Actions
Copy link

Bug #4201

closed

ndn-autoconfig should register / instead of /ndn

Added by Junxiao Shi over 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Junxiao Shi
Category:
Tools
Target version:
v0.6
Start date:
Due date:
% Done:

100%

Estimated time:
0.50 h

Description

ndn-autoconfig tool is intended to connect an end host to the NDN testbed.
In the context of forwarding hints (#3000), an end host should be considered part of the consumer region if an Interest originates from that end host.
As decided in #3000-7, hosts in consumer region should use / instead of /ndn as default route.
Therefore, ndn-autoconfig should register / instead of /ndn toward the discovered testbed router.

Actions
Copy link
 #1

Updated by Junxiao Shi over 7 years ago

  • Assignee set to Md Ashiqur Rahman
Actions
Copy link
 #2

Updated by Md Ashiqur Rahman over 7 years ago

I see that "/ndn" registration is done under NFD/tools/ndn-autoconfig in base.cpp at line 96.

void
Base::registerAutoConfigNames(uint64_t faceId)
{
  static const Name TESTBED_PREFIX = "/ndn";
  registerPrefix(TESTBED_PREFIX, faceId);

  static const Name LOCALHOP_NFD_PREFIX = "/localhop/nfd";
  registerPrefix(LOCALHOP_NFD_PREFIX, faceId);
}

Should only this needs be updated or do I have to detect if a host is in consumer region first?

Actions
Copy link
 #3

Updated by Junxiao Shi over 7 years ago

ndn-autoconfig is designed to run on an end host which is always consumer region, so there's no detection needed.
Base::registerAutoConfigNames and affected test cases shall be updated.

Actions
Copy link
 #4

Updated by Md Ashiqur Rahman over 7 years ago

I edited the code and tested the unit-tests under build and got no errors. What should be the next step?

Actions
Copy link
 #5

Updated by Junxiao Shi over 7 years ago

See NFD contributing guide for next steps.

Actions
Copy link
 #6

Updated by Md Ashiqur Rahman over 7 years ago

When preparing for contribution, adding Gerrit as a remote location to my local git repo, I see that when I do git clone ssh://Ashiq@gerrit.named-data.net:29418/NFD.git , there are changes in the repo and the /ndn registration now is under tools/ndn-autoconfig/procedure.cpp file in line 40:

static const std::vector<Name> HUB_PREFIXES{"/ndn", "/localhop/nfd"};

I believe I need to modify this. Please correct me if I'm wrong

Actions
Copy link
 #7

Updated by Md Ashiqur Rahman over 7 years ago

  • Status changed from New to Code review
Actions
Copy link
 #8

Updated by Davide Pesavento over 7 years ago

  • Status changed from Code review to Closed
  • % Done changed from 0 to 100
  • Estimated time changed from 1.00 h to 0.50 h
Actions
Copy link
 #9

Updated by Junxiao Shi over 6 years ago

  • Status changed from Closed to Feedback

Reopening: ndn-autoconfig manpage needs to reflect this change.

Actions
Copy link
 #10

Updated by Junxiao Shi over 6 years ago

  • Status changed from Feedback to Code review
  • Assignee changed from Md Ashiqur Rahman to Junxiao Shi
Actions
Copy link
 #11

Updated by Junxiao Shi over 6 years ago

As I'm editing ndn-autoconfig manpage, I find the separation of "NDN hub discovery procedure" and "client procedure" confusing. I propose merging these two sections. What does others think?

Actions
Copy link
 #12

Updated by Junxiao Shi over 6 years ago

  • Status changed from Code review to Closed
  • Start date deleted (07/23/2017)
Actions
Copy link

Also available in: Atom PDF