Actions
Bug #4244
closed
Face/TestWebSocketChannel/SetPingInterval is too strict
Start date:
Due date:
% Done:
100%
Estimated time:
0.50 h
Description
We only give it 30ms of tolerance, which is not enough, especially on Travis-CI, e.g. https://travis-ci.org/named-data/NFD/jobs/263911902
As a result, the test case is unstable and often fails.
../tests/daemon/face/websocket-channel.t.cpp:297: error: in "Face/TestWebSocketChannel/SetPingInterval": check measuredPingInterval <= pingInterval * 1.1 has failed [347825000 nanoseconds > 330 milliseconds]
Updated by Junxiao Shi over 6 years ago
I'll disagree with changing the 10% tolerance. I can agree with changing the "ping interval" so that the absolute tolerance would be higher. For example, setting "ping interval" to 800ms would tolerate 80ms of difference.
Updated by Davide Pesavento over 6 years ago
Yes, the problem is the absolute tolerance of 30ms, not the relative 10%.
Updated by Junxiao Shi over 6 years ago
- Status changed from New to In Progress
- Assignee set to Junxiao Shi
- Estimated time set to 0.50 h
Updated by Junxiao Shi over 6 years ago
- Category changed from Integration Tests to Faces
- Status changed from In Progress to Code review
- % Done changed from 0 to 100
Updated by Davide Pesavento over 6 years ago
- Status changed from Code review to Closed
Updated by Davide Pesavento over 6 years ago
Apparently 80ms are still not enough... http://jenkins.named-data.net/job/NFD/5765/OS=OSX-10.10/testReport/junit/Daemon.Tests.Face/TestWebSocketChannel/SetPingInterval/
Actions