Project

General

Profile

Feature #4288

Move sequence number file setting to the constructor

Added by Nicholas Gordon almost 2 years ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:

Description

Currently the SequencingManager relies on Nlsr::initialize to be in a valid state regarding the path for its sequence number file. Instead, it should be done at constructor time, and not rely on an external function.


Related issues

Blocked by NLSR - Task #1952: Decouple classes from Nlsr object for easier unit testingClosed

History

#1 Updated by Nicholas Gordon over 1 year ago

  • Target version changed from v0.4.0 to v0.5.0

#2 Updated by Nicholas Gordon over 1 year ago

  • Target version changed from v0.5.0 to Minor release 0.4.1

#3 Updated by Ashlesh Gawande over 1 year ago

  • Related to Task #1952: Decouple classes from Nlsr object for easier unit testing added

#4 Updated by Nicholas Gordon over 1 year ago

  • Related to deleted (Task #1952: Decouple classes from Nlsr object for easier unit testing)

#5 Updated by Nicholas Gordon over 1 year ago

  • Blocked by Task #1952: Decouple classes from Nlsr object for easier unit testing added

#6 Updated by Ashlesh Gawande over 1 year ago

  • Target version changed from Minor release 0.4.1 to v0.5.0

#7 Updated by Nicholas Gordon about 1 year ago

  • Assignee deleted (Nicholas Gordon)

This work should still be done. Unfortunately, the path of the file containing the sequence numbers is not set during ctor time, and that path is not available until Nlsr::initialize. This means that this change would require a change in that class, too.

#8 Updated by Ashlesh Gawande 6 months ago

  • Status changed from New to Code review
  • Assignee set to Ashlesh Gawande

#9 Updated by Ashlesh Gawande 5 months ago

  • Tracker changed from Task to Feature
  • Status changed from Code review to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF