Project

General

Profile

Task #1952

Feature #3744: Modularize NLSR

Decouple classes from Nlsr object for easier unit testing

Added by Vince Lehman almost 5 years ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:

Description

Currently, multiple objects use an Nlsr object as a parameter in their constructor. This makes unit tests difficult since an Nlsr object must be initialized to test these components.

Classes:

  • HelloProtocol

  • Lsdb

  • NamePrefixTable

  • FileProcessor

Instead, the objects should take the information they require from Nlsr as parameters.


Related issues

Related to NLSR - Task #4839: Move setInfoInterestFilter and setLsaInterestFilter to their respective classesNew

Blocks NLSR - Feature #4288: Move sequence number file setting to the constructorClosed

History

#1 Updated by Nicholas Gordon about 2 years ago

#2 Updated by Nicholas Gordon about 2 years ago

  • Parent task set to #3744

#3 Updated by Nicholas Gordon about 2 years ago

  • Target version set to v0.5.0

#4 Updated by Nicholas Gordon over 1 year ago

  • Assignee set to Nicholas Gordon
  • Target version changed from v0.5.0 to Minor release v0.5.1

#5 Updated by Ashlesh Gawande over 1 year ago

  • Related to Feature #4288: Move sequence number file setting to the constructor added

#6 Updated by Nicholas Gordon over 1 year ago

  • Related to deleted (Feature #4288: Move sequence number file setting to the constructor)

#7 Updated by Nicholas Gordon over 1 year ago

  • Blocks Feature #4288: Move sequence number file setting to the constructor added

#8 Updated by Nicholas Gordon about 1 year ago

  • Assignee deleted (Nicholas Gordon)

#9 Updated by Ashlesh Gawande 6 months ago

  • Status changed from New to Code review
  • Assignee set to Ashlesh Gawande
  • Target version changed from Minor release v0.5.1 to v0.5.0
  • Start date deleted (08/29/2014)

#10 Updated by Ashlesh Gawande 6 months ago

Current change, https://gerrit.named-data.net/c/NLSR/+/4398, does not pass individual components in the ctor if they are too many (example lsdb) but instead takes ConfParameter which has all parameters configured at the time of ctor initialization. It does resolve passing Nlsr to ConfFileProcessor and making things easier to initialize along with making classes independent of Nlsr object. Current change also does not enhance any tests, just make them compile and pass.

#11 Updated by Ashlesh Gawande 5 months ago

  • Status changed from Code review to Closed
  • % Done changed from 0 to 100

#12 Updated by Ashlesh Gawande 5 months ago

  • Related to Task #4839: Move setInfoInterestFilter and setLsaInterestFilter to their respective classes added

Also available in: Atom PDF