Project

General

Profile

Actions
Copy link

Task #1952

closed

Feature #3744: Modularize NLSR

Decouple classes from Nlsr object for easier unit testing

Added by Vince Lehman about 10 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ashlesh Gawande
Target version:
v0.5.0
Start date:
Due date:
% Done:

100%

Estimated time:

Description

Currently, multiple objects use an Nlsr object as a parameter in their constructor. This makes unit tests difficult since an Nlsr object must be initialized to test these components.

Classes:

  • HelloProtocol

  • Lsdb

  • NamePrefixTable

  • FileProcessor

Instead, the objects should take the information they require from Nlsr as parameters.

Related issues 2 (1 open — 1 closed)

Related to NLSR - Task #4839: Move setInfoInterestFilter and setLsaInterestFilter to their respective classesNewSaurab Dulal

Actions
Blocks NLSR - Feature #4288: Move sequence number file setting to the constructorClosedAshlesh Gawande

Actions
Actions
Copy link
 #1

Updated by Nicholas Gordon over 7 years ago

Actions
Copy link
 #2

Updated by Nicholas Gordon over 7 years ago

  • Parent task set to #3744
Actions
Copy link
 #3

Updated by Nicholas Gordon over 7 years ago

  • Target version set to v0.5.0
Actions
Copy link
 #4

Updated by Nicholas Gordon almost 7 years ago

  • Assignee set to Nicholas Gordon
  • Target version changed from v0.5.0 to Minor release v0.5.1
Actions
Copy link
 #5

Updated by Ashlesh Gawande almost 7 years ago

  • Related to Feature #4288: Move sequence number file setting to the constructor added
Actions
Copy link
 #6

Updated by Nicholas Gordon almost 7 years ago

  • Related to deleted (Feature #4288: Move sequence number file setting to the constructor)
Actions
Copy link
 #7

Updated by Nicholas Gordon almost 7 years ago

  • Blocks Feature #4288: Move sequence number file setting to the constructor added
Actions
Copy link
 #8

Updated by Nicholas Gordon over 6 years ago

  • Assignee deleted (Nicholas Gordon)
Actions
Copy link
 #9

Updated by Ashlesh Gawande almost 6 years ago

  • Status changed from New to Code review
  • Assignee set to Ashlesh Gawande
  • Target version changed from Minor release v0.5.1 to v0.5.0
  • Start date deleted (08/29/2014)
Actions
Copy link
 #10

Updated by Ashlesh Gawande almost 6 years ago

Current change, https://gerrit.named-data.net/c/NLSR/+/4398, does not pass individual components in the ctor if they are too many (example lsdb) but instead takes ConfParameter which has all parameters configured at the time of ctor initialization. It does resolve passing Nlsr to ConfFileProcessor and making things easier to initialize along with making classes independent of Nlsr object. Current change also does not enhance any tests, just make them compile and pass.

Actions
Copy link
 #11

Updated by Ashlesh Gawande almost 6 years ago

  • Status changed from Code review to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #12

Updated by Ashlesh Gawande almost 6 years ago

  • Related to Task #4839: Move setInfoInterestFilter and setLsaInterestFilter to their respective classes added
Actions
Copy link

Also available in: Atom PDF