Feature #4570: Redesign Name::getSuccessor - ndn-cxx - NDN project issue tracking system

Actions

Copy link

Feature #4570

closed

Redesign Name::getSuccessor

Added by Junxiao Shi over 6 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Junxiao Shi

Category:

Base

Target version:

v0.7

Start date:

Due date:

% Done:

100%

Estimated time:

2.00 h

Tags:

Packet03Transition

Description

Name::getSuccessor returns the "successor" of a name.
As of ndn-cxx 0.6.1, this is defined as:

   *  The successor of a name is defined as follows:
   *
   *      N represents the set of NDN Names, and X,Y ∈ N.
   *      Operator < is defined by canonical order on N.
   *      Y is the successor of X, if (a) X < Y, and (b) ∄ Z ∈ N s.t. X < Z < Y.
   *
   *  In plain words, successor of a name is the same name, but with its last component
   *  advanced to a next possible value.
   *
   *  Examples:
   *
   *  - successor for / is /%00
   *  - successor for /%00%01/%01%02 is /%00%01/%01%03
   *  - successor for /%00%01/%01%FF is /%00%01/%02%00
   *  - successor for /%00%01/%FF%FF is /%00%01/%00%00%00

With ImplicitSha256DigestComponent and typed name components (#4526) in Packet03Transition, the implementation and examples no longer match the definition.
According to the definition,

successor for / is /sha256digest=00000000000000000000000000000000.
successor for /sha256digest=ffffffffffffffffffffffffffffffff is /2=....
all other cases: the last component does not change type.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Junxiao Shi over 6 years ago

Blocked by Feature #4526: Recognize typed name components added

Actions

Copy link

Updated by Junxiao Shi over 6 years ago

Description updated (diff)

While it is trivial to update the implementation, I doubt the necessity of Component::getSuccessor and Name::getSuccessor functions.

From #1677-1:

Successor of name is needed by repo-ng to handle rightmost selector.

Packet Format v0.3 removes ChildSelector, so CS and repo index do not need to handle rightmost selector.
Is there any other use case? If not, I propose to deprecate and eliminate getSuccessor.

Actions

Copy link

Updated by Davide Pesavento over 6 years ago

Should this be fixed for 0.6.2?

Actions

Copy link

Updated by Junxiao Shi over 6 years ago

Should this be fixed for 0.6.2?

This does not block v0.6.2 release. The problem is not caused by the introduction of typed name components. It existed since ImplicitSha256DigestComponent, and nothing is noticably broken so far.

Actions

Copy link