Bug #4624
closed
Preparation folder incorrectly collected with logs in Vagrant environments
Added by Eric Newberry almost 6 years ago.
Updated almost 6 years ago.
Category:
Integration Tests
Description
As reported in #4379 note 6, the Vagrant testing script is incorrectly capturing the prepare folder when collecting logs, causing several gigabytes of source code, intermediate files, libraries, and
executables to be copied with the logs. These should be excluded from the Vagrant log collection script.
Files
- Status changed from New to In Progress
- Status changed from In Progress to Code review
- % Done changed from 0 to 100
I realized that the simplest way to accomplish this is to delete the prepare directory from the template VM after all packages are installed.
I also modified the log collection script to prevent it from re-collecting the logs directory in the event the integration tests are run twice in the same directory.
Change 4774 patchset 1 does not work as claimed.
logs/*/install_helpers/tools/* binaries are collected but they shouldn't.
I also suggest fixing #4411 together as both problems are in the same script.
Junxiao Shi wrote:
Change 4774 patchset 1 does not work as claimed.
logs/*/install_helpers/tools/* binaries are collected but they shouldn't.
Nitpick: I never claimed it didn't collect files in this path, only the prepare and logs directories. However, this is a good observation and will be corrected in the next patchset.
I also suggest fixing #4411 together as both problems are in the same script.
That's a good idea. I'll integrate that with the next patchset.
- Related to Bug #4411: awk warning from collect-logs.sh added
The fix to this issue actually broke log collection. It now excludes every folder named "logs*", which means that most logs are excluded from collection. This can be fixed by changing the relevant exclude to "./logs*" in the tar command in collect-logs.sh. I'm planning to fix this in the commit for #4379.
Also available in: Atom
PDF
Updated by 
Updated by