Project

General

Profile

Actions

Feature #4720

closed

Global counter for satisfied/unsatisfied Interests

Added by Davide Pesavento over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Management
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
4.50 h

Description

Add two counters to ForwarderStatus's GeneralStatus dataset:

  • number of satisfied Interests, incremented when a PIT entry that has been satisfied is being removed
  • number of unsatisfied Interests, incremented when a PIT entry that has not been satisfied is being removed

These are global forwarder counters, not per-face counters.

Actions #1

Updated by Davide Pesavento over 6 years ago

Beichuan asked for this feature during the 2018-08-20 NDN Platform call.

The definition of "unsatisfied Interest" needs to be clarified. Does it include currently pending Interests or not? Does it include Nacked Interests or only timeouts?

Actions #2

Updated by Junxiao Shi over 6 years ago

  • Subject changed from Add global counter for the number of unsatisfied Interests to Global counter for satisfied/unsatisfied Interests
  • Description updated (diff)
  • Assignee set to Sepehr Abdous
  • Target version set to v0.7
  • Estimated time set to 4.50 h

Developer should follow these steps:

  1. Define protocol on ForwarderStatus wiki page. Get it approved in NFD call.
  2. Add the fields in ndn::nfd::ForwarderStatus type.
  3. Declare two PacketCounters in nfd::ForwarderCounters struct.
  4. Increment either counter in Forwarder::onInterestFinalize function.
  5. Assign counter values in ForwarderStatusManager::collectGeneralStatus, and update test cases. Step 3-5 belong to the same commit.
  6. Display counter values in nfdc status command output, and update test cases.
  7. Display counter values in status http page. Step 6-7 belong to the same commit.

If you haven't already, review all articles in NFD wiki "HOWTOs for n00bs" section.

Actions #3

Updated by Sepehr Abdous over 6 years ago

  • Status changed from New to In Progress
Actions #4

Updated by Davide Pesavento over 6 years ago

Junxiao Shi wrote:

Display counter values in status http page. Step 6-7 belong to the same commit.

And don't forget to update nfd-status.xsd in that commit.

Actions #5

Updated by Davide Pesavento about 6 years ago

  • Status changed from In Progress to New
  • Assignee deleted (Sepehr Abdous)
  • Target version deleted (v0.7)
Actions #6

Updated by Ju Pan about 6 years ago

  • Status changed from New to In Progress
  • Assignee set to Ju Pan
Actions #7

Updated by Ju Pan about 6 years ago

  • % Done changed from 0 to 70
Actions #8

Updated by Davide Pesavento about 6 years ago

  • Status changed from In Progress to Code review
  • Target version set to v0.7
Actions #9

Updated by Davide Pesavento about 6 years ago

  • Status changed from Code review to Closed
  • % Done changed from 70 to 100
Actions

Also available in: Atom PDF