Project

General

Profile

Actions

Feature #4816

closed

Display FIB nexthop endpoint ID in status dataset

Added by Junxiao Shi about 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Management
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
6.00 h

Description

In FibMgmt, include nexthop record’s endpoint ID in status dataset.
This issue includes protocol update and implementation in ndn-cxx, nfd, nfdc, XSLT.


Related issues 1 (0 open1 closed)

Blocked by NFD - Feature #4284: FIB EndpointId columnClosedMd Ashiqur Rahman

Actions
Actions #1

Updated by Junxiao Shi about 5 years ago

Actions #2

Updated by Ju Pan almost 5 years ago

  • Status changed from New to In Progress
  • Assignee set to Ju Pan
  • Estimated time set to 6.00 h
Actions #3

Updated by Ju Pan almost 5 years ago

I knew nothing about NFD mgmt before, I am reading NFD developer guide "Management" section, NFD Management Protocol on Wiki page, and the source code. Are there any other materials I could refer to? Thanks!

Actions #4

Updated by Davide Pesavento almost 5 years ago

Not that I know of.

Actions #5

Updated by Ju Pan almost 5 years ago

Just want to make sure I am on the correct direction before changing the code.

To "include nexthop record’s endpoint ID in status dataset", I need to:

  1. In ndn-cxx/ndn-cxx/mgmt/nfd/fib-entry.hpp, add a "m_endpointID" private field and corresponding get and set methond. And modify the fib-entry.cpp file.
  2. In NFD/daemon/mgmt/fib-manager.cpp, at line 128, add "setEndpointID(...)"
Actions #6

Updated by Davide Pesavento almost 5 years ago

  • Start date deleted (01/25/2019)

Yes, that seems correct to me. Don't forget to update the protocol in FibMgmt.

Actions #7

Updated by Davide Pesavento almost 5 years ago

  • Description updated (diff)
Actions #8

Updated by Ju Pan almost 5 years ago

Two equal NextHopRecords should have the same EndpointId, right?

Actions #9

Updated by Davide Pesavento almost 5 years ago

Yes.

Actions #10

Updated by Ju Pan almost 5 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 0 to 80
Actions #11

Updated by Junxiao Shi almost 5 years ago

FibMgmt rev41 assigns 0x71 to EndpointId in dataset. Any reason not to use a number in application range, i.e. 0x80 or above?

Actions #12

Updated by Ju Pan almost 5 years ago

No, there is no reason. I don't know there is a range requirement. Do I need to reassign a value?

Actions #13

Updated by Davide Pesavento almost 5 years ago

Junxiao Shi wrote:

FibMgmt rev41 assigns 0x71 to EndpointId in dataset. Any reason not to use a number in application range, i.e. 0x80 or above?

A lot of type assignments in NFD mgmt protocol already use numbers below 0x80, I don't see the problem.

Actions #14

Updated by Junxiao Shi almost 5 years ago

A lot of type assignments in NFD mgmt protocol already use numbers below 0x80, I don't see the problem.

So far, only TLV-TYPEs in ControlCommand use [101, 127] range. Otherwise, they use application range.


https://gerrit.named-data.net/5463 patchset4 displays FaceId+EndpointId as:

faceid=262 (endpointId=1, cost=9)

This is not quite right, because FaceId and EndpointId together identify a nexthop, while cost is an attribute of the nexthop.

The syntax should be:

face=262~1 (cost=9)
Actions #15

Updated by Ju Pan almost 5 years ago

The syntax should be:

face=262~1 (cost=9)

Should we omit the EndpointID if it's 0, like
face=262 (cost=9)

Actions #16

Updated by Junxiao Shi almost 5 years ago

Should we omit the EndpointID if it's 0, like
face=262 (cost=9)

Yes, that's fine.

Actions #17

Updated by Davide Pesavento almost 5 years ago

  • Target version set to v0.7
  • % Done changed from 80 to 100
Actions #18

Updated by Davide Pesavento almost 5 years ago

Actions #19

Updated by Davide Pesavento almost 5 years ago

Actions #20

Updated by Ju Pan almost 5 years ago

  • Status changed from Code review to Closed
Actions #21

Updated by Davide Pesavento over 4 years ago

These changes have been reverted, see #4973.

Actions

Also available in: Atom PDF