Project

General

Profile

Actions
Copy link

Task #4825

closed

IBLT::extractValueFromName can be static

Added by Anonymous almost 6 years ago. Updated 10 months ago.

Status:
Closed
Priority:
Low
Assignee:
Junxiao Shi
Target version:
-
Start date:
01/29/2019
Due date:
% Done:

100%

Estimated time:

Description

The method IBLT::extractValueFromName does not access variables of the IBLT object. It can be declared static.
https://github.com/named-data/PSync/blob/0cf4b600e91455ee07c38eb22876aa6b653bc14b/PSync/detail/iblt.cpp#L272

(This is a low-priority observation. Feel free to ignore it if you want.)

Actions
Copy link
 #1

Updated by Junxiao Shi 11 months ago

  • Status changed from New to In Progress
  • Assignee set to Junxiao Shi
  • % Done changed from 0 to 60
Actions
Copy link
 #2

Updated by Junxiao Shi 11 months ago

I performed some refactoring of the encode/decode routines in the Change.
Most notably, the extractValueFromName function is merged into the initialize function, to eliminate the unnecessary construction of a std::vector<uint32_t>.

Actions
Copy link
 #3

Updated by Junxiao Shi 10 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 60 to 100
Actions
Copy link

Also available in: Atom PDF