Project

General

Profile

Task #4883

Move ndn::util::scheduler to ndn::scheduler

Added by Junxiao Shi 6 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Low
Category:
Utils
Target version:
Start date:
03/15/2019
Due date:
% Done:

100%

Estimated time:
Tags:

History

#1 Updated by Davide Pesavento 6 months ago

  • Tracker changed from Feature to Task
  • Priority changed from Normal to Low
  • Start date changed from 03/16/2019 to 03/15/2019
  • % Done changed from 0 to 30

#2 Updated by Davide Pesavento 6 months ago

  • % Done changed from 30 to 70

#3 Updated by Junxiao Shi 6 months ago

In https://gerrit.named-data.net/5326, NFD is switching from nfd::scheduler::schedule function to ndn::Scheduler::scheduleEvent call. The scheduleEvent function name seems too long. Shall we alias it to just schedule?

#4 Updated by Davide Pesavento 6 months ago

No preference.

#5 Updated by Junxiao Shi 6 months ago

https://gerrit.named-data.net/5329 performs the rename. It allows vertical shortening in several places, such as tests/unit/security/signature-sha256-with-ecdsa.t.cpp.
I also did some deduplication in SegmentFetcher.

#6 Updated by Davide Pesavento 6 months ago

Junxiao Shi wrote:

It allows vertical shortening in several places, such as tests/unit/security/signature-sha256-with-ecdsa.t.cpp.

No, not "several", that is the only place in ndn-cxx where this shortening makes any actual difference.

#7 Updated by Davide Pesavento 6 months ago

  • Status changed from In Progress to Code review
  • % Done changed from 70 to 100

#8 Updated by Davide Pesavento 6 months ago

  • Status changed from Code review to Feedback

#9 Updated by Davide Pesavento 5 months ago

  • Tags set to CodeCleanup

#10 Updated by Davide Pesavento 5 months ago

  • Status changed from Feedback to Closed

#11 Updated by Junxiao Shi 4 months ago

  • Status changed from Closed to Feedback

NLSR appears to be broken again. It seems that some new deprecated usage was introduced after https://gerrit.named-data.net/5327 has been merged.

#12 Updated by Junxiao Shi 4 months ago

  • Status changed from Feedback to Closed

NLSR appears to be broken again.

Sorry, it's my devbox problem: I forgot to pull PSync changes.

Also available in: Atom PDF