Project

General

Profile

Actions

Task #4883

closed

Move ndn::util::scheduler to ndn::scheduler

Added by Junxiao Shi over 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Low
Category:
Utils
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Actions #1

Updated by Davide Pesavento over 5 years ago

  • Tracker changed from Feature to Task
  • Priority changed from Normal to Low
  • Start date changed from 03/16/2019 to 03/15/2019
  • % Done changed from 0 to 30
Actions #2

Updated by Davide Pesavento over 5 years ago

  • % Done changed from 30 to 70
Actions #3

Updated by Junxiao Shi over 5 years ago

In https://gerrit.named-data.net/5326, NFD is switching from nfd::scheduler::schedule function to ndn::Scheduler::scheduleEvent call. The scheduleEvent function name seems too long. Shall we alias it to just schedule?

Actions #4

Updated by Davide Pesavento over 5 years ago

No preference.

Actions #5

Updated by Junxiao Shi over 5 years ago

https://gerrit.named-data.net/5329 performs the rename. It allows vertical shortening in several places, such as tests/unit/security/signature-sha256-with-ecdsa.t.cpp.
I also did some deduplication in SegmentFetcher.

Actions #6

Updated by Davide Pesavento over 5 years ago

Junxiao Shi wrote:

It allows vertical shortening in several places, such as tests/unit/security/signature-sha256-with-ecdsa.t.cpp.

No, not "several", that is the only place in ndn-cxx where this shortening makes any actual difference.

Actions #7

Updated by Davide Pesavento over 5 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 70 to 100
Actions #8

Updated by Davide Pesavento over 5 years ago

  • Status changed from Code review to Feedback
Actions #9

Updated by Davide Pesavento over 5 years ago

  • Tags set to CodeCleanup
Actions #10

Updated by Davide Pesavento over 5 years ago

  • Status changed from Feedback to Closed
Actions #11

Updated by Junxiao Shi over 5 years ago

  • Status changed from Closed to Feedback

NLSR appears to be broken again. It seems that some new deprecated usage was introduced after https://gerrit.named-data.net/5327 has been merged.

Actions #12

Updated by Junxiao Shi over 5 years ago

  • Status changed from Feedback to Closed

NLSR appears to be broken again.

Sorry, it's my devbox problem: I forgot to pull PSync changes.

Actions #13

Updated by Davide Pesavento over 4 years ago

  • Tags changed from CodeCleanup to code-cleanup
  • Start date deleted (03/15/2019)
Actions

Also available in: Atom PDF