Project

General

Profile

Actions

Bug #4908

closed

Macro name conflict

Added by Ryan Wickman almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Start date:
04/06/2019
Due date:
% Done:

100%

Estimated time:

Description

In src/common.hpp the macros (e.g., PUBLIC_WITH_TESTS_ELSE_PRIVATE) conflict with the ones found in the other projects, such as ndn-tools. So if you try to build ndn-tools with tests and NAC, the tests compilation will produce an error since they will try to use the private members of a class (which should be public).

To resolve this issue, prefix the macros with NAC_.

Actions #1

Updated by Davide Pesavento almost 5 years ago

  • Status changed from New to In Progress
  • Assignee set to Davide Pesavento
  • Start date changed from 04/05/2019 to 04/06/2019
Actions #2

Updated by Davide Pesavento almost 5 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 0 to 100
Actions #3

Updated by Davide Pesavento almost 5 years ago

  • Status changed from Code review to Closed
Actions

Also available in: Atom PDF