Project

General

Profile

Actions

Bug #5010

closed

NLSR tries to recreate existing routes on FACE_EVENT_CREATED

Added by Ashlesh Gawande about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:

Description

1) NLSR fetches face dataset from NFD and creates routes to neighbors using corresponding face ids received in the face dataset
2) NLSR receives FACE_EVENT_CREATED with the neighbor faces (not sure why - because faces were created before NLSR was started).
3) NLSR does not check that we already have the face id set on the neighbor
4) NLSR proceeds to register routes again (harmless, but wasted)

Comment says about zero, but implementation is not there. There is an existing unit test to check this, but it is completely broken.

Solution:
NLSR should only proceed to register routes if known face id of neighbor is zero or the known face id is different from the received face id.


Related issues 1 (0 open1 closed)

Related to NLSR - Task #5011: Use own registration reply instead of dummy face'sClosedJunxiao Shi

Actions
Actions #1

Updated by Ashlesh Gawande about 5 years ago

  • Related to Task #5011: Use own registration reply instead of dummy face's added
Actions #2

Updated by Ashlesh Gawande about 5 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 0 to 100
Actions #3

Updated by Ashlesh Gawande about 5 years ago

  • Status changed from Code review to Closed
Actions #4

Updated by Ashlesh Gawande about 5 years ago

  • Target version changed from v0.5.0 to Minor release v0.5.2
Actions

Also available in: Atom PDF