Project

General

Profile

Actions

Feature #5104

closed

Shorten Nack encoding

Added by Junxiao Shi over 4 years ago. Updated over 4 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
Base
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
3.00 h

Description

When encoding Nack, only include Name, CanBePrefix, MustBeFresh, ForwardingHint, and Nonce elements of the Interest. Omit other fields.
Change Interest-to-Nack matching functions accordingly.


Related issues 2 (0 open2 closed)

Related to NFD - Feature #4535: Nack format for Interest v0.3RejectedJunxiao Shi

Actions
Blocks NFD - Feature #5105: PIT lookup with shortened NackRejected

Actions
Actions #1

Updated by Junxiao Shi over 4 years ago

Actions #2

Updated by Junxiao Shi over 4 years ago

Actions #3

Updated by Junxiao Shi over 4 years ago

Actions #4

Updated by Davide Pesavento over 4 years ago

Why is this blocked by #4804?

Actions #5

Updated by Junxiao Shi over 4 years ago

Why is this blocked by #4804?

This is to prevent merge conflicts.

Actions #6

Updated by Davide Pesavento over 4 years ago

Actions #7

Updated by Eric Newberry over 4 years ago

  • Assignee set to Eric Newberry
Actions #8

Updated by Eric Newberry over 4 years ago

It seems this will require changes to both ndn-cxx and NFD, since they each have their own Nack encoding mechanisms in their respective face systems. Is this correct?

Actions #9

Updated by Junxiao Shi over 4 years ago

Eric Newberry wrote:

It seems this will require changes to both ndn-cxx and NFD, since they each have their own Nack encoding mechanisms in their respective face systems. Is this correct?

No. NFD change is #5105.

Actions #10

Updated by Eric Newberry over 4 years ago

So, if I'm understanding this issue correctly, the Interest-to-Nack matching function will need to be changed so that all five of the fields match, instead of just the first three as in the Interest-to-Interest matching function?

Actions #11

Updated by Junxiao Shi over 4 years ago

So, if I'm understanding this issue correctly, the Interest-to-Nack matching function will need to be changed so that all five of the fields match, instead of just the first three as in the Interest-to-Interest matching function?

I'm uncertain about library behavior. You can check how Python library is doing things.
Forwarder behavior is answered in #5105-3.

Actions #12

Updated by Eric Newberry over 4 years ago

  • Status changed from New to In Progress
Actions #13

Updated by Eric Newberry over 4 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 0 to 100
Actions #14

Updated by Eric Newberry over 4 years ago

At the NDN Platform Call on May 22, 2020, it was decided to revert this design decision and instead encode the entire original Interest in Nacks. Therefore, this change is not needed.

Actions #15

Updated by Davide Pesavento over 4 years ago

  • Status changed from Code review to Rejected
  • Target version deleted (0.9.0)
  • % Done changed from 100 to 0
Actions #16

Updated by Davide Pesavento over 4 years ago

  • Assignee deleted (Eric Newberry)
Actions

Also available in: Atom PDF