Project

General

Profile

Task #5173

Make strategy API more uniform

Added by Davide Pesavento 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Category:
Forwarding
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Tags:

Description

Currently, the public API available to forwarding strategies is fairly inconsistent wrt the order of function parameters. This is true for both actions and triggers.
For instance, to sent an Interest we have:

sendInterest(pit entry, egress face, interest packet)

but for Data the order is different:

sendData(pit entry, data packet, egress face)

and similarly for triggers, e.g., compare the following function signatures:

afterReceiveInterest (ingress,   interest packet, pit entry)
afterReceiveData     (pit entry, ingress,         data packet)
beforeSatisfyInterest(pit entry, ingress,         data packet)
afterReceiveNack     (ingress,   nack packet,     pit entry)

We'd like to make the API a bit more uniform and internally consistent by following this general ordering of the parameters for actions and triggers:

  • packet (Interest/Data/Nack)
  • face (ingress or egress)
  • pit entry
  • any other additional parameters
#1

Updated by Davide Pesavento 3 months ago

  • Status changed from In Progress to Code review
  • % Done changed from 0 to 100
#2

Updated by Davide Pesavento 3 months ago

  • Description updated (diff)
#3

Updated by Davide Pesavento 3 months ago

  • Tags set to API
  • Description updated (diff)
#4

Updated by Davide Pesavento 3 months ago

  • Status changed from Code review to Closed

Also available in: Atom PDF