Task #1128
closed
mock implementation of PIT
100%
Description
Implement a subset of PIT entry and PIT table functionality.
Pit class contains: insert, findAllDataMatches, remove
pit::Entry` class contains: getInterest, getName, getInRecords, getOutRecords, isNonceSeen, insertOrUpdateInRecord, deleteInRecords, insertOrUpdateOutRecord, deleteOutRecord
There is no performance requirement on this mock implementation.
Updated by Junxiao Shi almost 11 years ago
- Assignee set to Junxiao Shi
- Start date changed from 01/23/2014 to 01/24/2014
Updated by Junxiao Shi almost 11 years ago
- Due date changed from 01/27/2014 to 01/25/2014
- Start date deleted (
01/26/2014)
Updated by Junxiao Shi almost 11 years ago
- Status changed from New to In Progress
Updated by Junxiao Shi almost 11 years ago
- Due date changed from 01/25/2014 to 01/26/2014
Updated by Junxiao Shi almost 11 years ago
I need clarification on API:
- Should
fib::Entry::insertOrUpdateInRecordupdate lastNonce, lastRenewed, expiry fields in InRecord, or should the caller (forwarding) do it? - Should
fib::Entry::insertOrUpdateOutRecordupdate lastNonce, lastRenewed, expiry, isPending fields in OutRecord, or should the caller (forwarding) do it? - What API should forwarding use to set isPending of OutRecord to false?
Updated by Alex Afanasyev almost 11 years ago
I need clarification on API:
- Should
fib::Entry::insertOrUpdateInRecordupdate lastNonce, lastRenewed, expiry fields in InRecord, or should the caller (forwarding) do it?
The call has all necessary information (it is being passed reference to Interest), so it should do it itself.
- Should
fib::Entry::insertOrUpdateOutRecordupdate lastNonce, lastRenewed, expiry, isPending fields in OutRecord, or should the caller (forwarding) do it?
Same thing. I would say it should do it.
- What API should forwarding use to set isPending of OutRecord to false?
Good question. I again blanking on why we have it here. Isn't it supposed to be pending whenever OutRecord exists?
Updated by Junxiao Shi almost 11 years ago
Alex Afanasyev wrote:
What API should forwarding use to set isPending of OutRecord to false?
Good question. I again blanking on why we have it here. Isn't it supposed to be pending whenever OutRecord exists?
Yes, isPending is unnecessary since Nonces are stored in m_nonces field.
There should be a pit::Entry::deleteOutRecord method.
Updated by Junxiao Shi almost 11 years ago
- Status changed from In Progress to Code review
- % Done changed from 0 to 100
Updated by Junxiao Shi almost 11 years ago
- Status changed from Code review to Closed