Actions
Task #2099
closedMove definition of MAX_NDN_PACKET_SIZE
Start date:
Due date:
% Done:
100%
Estimated time:
1.00 h
Description
Move MAX_NDN_PACKET_SIZE out of common.hpp, because common.hpp is implementation detail and shouldn't be relied upon outside of ndn-cxx.
Delete the duplicate definition in NFD face/face.hpp.
      
      Updated by Junxiao Shi about 11 years ago
      
    
    - Related to Task #2098: Mark common.hpp as implementation detail added
 
      
      Updated by Junxiao Shi about 11 years ago
      
    
    - Related to Task #1920: Document 8800 octet limit for data packet size added
 
      
      Updated by Junxiao Shi about 11 years ago
      
    
    20141103 conference call suggests to put this constant in encoding/tlv.hpp.
      
      Updated by Junxiao Shi almost 11 years ago
      
    
    - Status changed from New to In Progress
 - Assignee set to Junxiao Shi
 
      
      Updated by Junxiao Shi almost 11 years ago
      
    
    - Status changed from In Progress to Code review
 - % Done changed from 0 to 100
 
      
      Updated by Junxiao Shi almost 11 years ago
      
    
    - Status changed from Code review to In Progress
 - % Done changed from 100 to 50
 
This Task shall also delete the duplicate definition in NFD face/face.hpp.
      
      Updated by Junxiao Shi almost 11 years ago
      
    
    - Status changed from In Progress to Code review
 - % Done changed from 50 to 100
 
NFD change http://gerrit.named-data.net/1405
It's intentional that the constant isn't imported into namespace nfd, because it's not widely used, and I don't see a need to import it.
      
      Updated by Alex Afanasyev almost 11 years ago
      
    
    - Status changed from Code review to Closed
 
Actions