Task #2099
closed
Move definition of MAX_NDN_PACKET_SIZE
Added by Junxiao Shi over 9 years ago.
Updated over 9 years ago.
Description
Move MAX_NDN_PACKET_SIZE out of common.hpp, because common.hpp is implementation detail and shouldn't be relied upon outside of ndn-cxx.
Delete the duplicate definition in NFD face/face.hpp.
- Related to Task #2098: Mark common.hpp as implementation detail added
- Related to Task #1920: Document 8800 octet limit for data packet size added
20141103 conference call suggests to put this constant in encoding/tlv.hpp.
- Status changed from New to In Progress
- Assignee set to Junxiao Shi
- Status changed from In Progress to Code review
- % Done changed from 0 to 100
- Status changed from Code review to In Progress
- % Done changed from 100 to 50
This Task shall also delete the duplicate definition in NFD face/face.hpp.
- Status changed from In Progress to Code review
- % Done changed from 50 to 100
NFD change http://gerrit.named-data.net/1405
It's intentional that the constant isn't imported into namespace nfd, because it's not widely used, and I don't see a need to import it.
- Status changed from Code review to Closed
Also available in: Atom
PDF
Updated by 
Updated by