Project

General

Profile

Task #2099

Move definition of MAX_NDN_PACKET_SIZE

Added by Junxiao Shi almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Base
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
1.00 h

Description

Move MAX_NDN_PACKET_SIZE out of common.hpp, because common.hpp is implementation detail and shouldn't be relied upon outside of ndn-cxx.

Delete the duplicate definition in NFD face/face.hpp.


Related issues

Related to ndn-cxx - Task #2098: Mark common.hpp as implementation detailClosed

Related to NFD - Task #1920: Document 8800 octet limit for data packet sizeClosed

History

#1 Updated by Junxiao Shi almost 5 years ago

  • Related to Task #2098: Mark common.hpp as implementation detail added

#2 Updated by Junxiao Shi almost 5 years ago

  • Related to Task #1920: Document 8800 octet limit for data packet size added

#3 Updated by Junxiao Shi almost 5 years ago

20141103 conference call suggests to put this constant in encoding/tlv.hpp.

#4 Updated by Junxiao Shi almost 5 years ago

  • Status changed from New to In Progress
  • Assignee set to Junxiao Shi

#5 Updated by Junxiao Shi almost 5 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 0 to 100

#6 Updated by Junxiao Shi almost 5 years ago

  • Status changed from Code review to In Progress
  • % Done changed from 100 to 50

This Task shall also delete the duplicate definition in NFD face/face.hpp.

#7 Updated by Junxiao Shi almost 5 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 50 to 100

NFD change http://gerrit.named-data.net/1405

It's intentional that the constant isn't imported into namespace nfd, because it's not widely used, and I don't see a need to import it.

#8 Updated by Alex Afanasyev almost 5 years ago

  • Status changed from Code review to Closed

Also available in: Atom PDF