Task #2111
closed
- Estimated time set to 1.00 h
Although all this takes is to declare a constant in MetaInfo
class, I can anticipate lots of objections as similar to #2021, so estimated time is set to 1 hour.
My objection to #2021 was partially based on the fact that it's a change to the TLV structure. An application that accidentally pulls one of the experimental Data packets will get a parse error (i.e. exception thrown by the library it uses) if its library isn't aware of the experimental change. This is a serious problem because the app/library will drop the Data packet without telling the application what the "bad" packet was. In other words, the application is in a position where it doesn't know how to avoid the "bad" packet (it was never told its name or implicit digest) and so the only thing it can do is re-request...which will likely just bring the "bad" packet in again. We should probably discuss this problem and potential solutions as a separate topic though (e.g. provide the "bad" packet's digest to the app via a callback).
I don't think there's any such problem here. It sounds like the proposal is to add a new content type value without changing the TLV structure. The only problem would be if parsers enforce acceptable content type values.
- Status changed from New to In Progress
- Assignee set to Junxiao Shi
- Status changed from In Progress to Code review
- % Done changed from 0 to 100
- Related to Task #2128: Deduplicate tlv::ContentTypeValue and MetaInfo::TYPE_* added
- Status changed from Code review to Closed
Also available in: Atom
PDF