Actions
Feature #2261
closed
Don't use exceptions in PartialMessageStore::receiveNdnlpData
Start date:
Due date:
% Done:
100%
Estimated time:
2.00 h
Description
Some time ago we made Face::decodeAndDispatchInput non-throwing, now it just returns false when there's a decode error.
The same should be done with PartialMessageStore::receiveNdnlpData.
Updated by Davide Pesavento almost 10 years ago
Also, should ndnlp::ParseError inherit from tlv::Error?
Updated by Junxiao Shi over 9 years ago
- Tracker changed from Task to Feature
- Subject changed from Handle all TLV decoding exceptions in PartialMessageStore::receiveNdnlpData to Don't use exceptions in PartialMessageStore::receiveNdnlpData
- Description updated (diff)
- Status changed from New to In Progress
- Start date deleted (
12/02/2014) - Estimated time set to 2.00 h
Updated by Junxiao Shi over 9 years ago
- Blocked by Bug #2552: Block::fromBuffer(ConstBufferPtr, size_t, Block&) unexpected decode error added
Updated by Junxiao Shi over 9 years ago
- % Done changed from 0 to 80
Updated by Junxiao Shi over 9 years ago
- Status changed from In Progress to Code review
- % Done changed from 80 to 100
Updated by Junxiao Shi over 9 years ago
- Status changed from Code review to In Progress
Reviewer suggests an API change to use move semantics, and mentions that Block::fromBuffer should apply the same change.
I'll wait for the change in Block::fromBuffer, to avoid using the deprecated overload of that function.
Updated by Junxiao Shi over 9 years ago
- Blocked by Feature #2553: Block::fromBuffer use move semantics added
Updated by Junxiao Shi over 9 years ago
- Status changed from In Progress to Code review
Updated by Junxiao Shi over 9 years ago
- Blocked by deleted (Feature #2553: Block::fromBuffer use move semantics)
Updated by Junxiao Shi over 9 years ago
- Status changed from Code review to Closed
Actions