Project

General

Profile

Task #2298

Rename nfd::EventId to nfd::scheduler::EventId

Added by Junxiao Shi almost 7 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
Core
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
1.00 h

Description

nfd::EventId is an alias of ndn::EventId, which is an opaque type representing ID of a scheduled event on a Scheduler.

However, bare EventId is not readable, because there's no hint of its association with Scheduler.

This Task is to change EventId to scheduler::EventId, to emphasize its association with nfd::scheduler.

#1

Updated by Alex Afanasyev almost 7 years ago

There is only one scheduler, why do you need additional association? Just "EventId" seem enough to represent that it is something about scheduled events.

I prefer keeping code as is.

#3

Updated by Alex Afanasyev almost 7 years ago

  • Subject changed from Eliminate nfd::EventId to Rename nfd::EventId to nfd::scheduler::EventId
  • Estimated time changed from 1.50 h to 0.50 h

In general, I'm against pointless changes of the existing code. I agree there could be some confusion with EventEmitter, but there shouldn't be confusing with Signal and Connections.

If you really want to make this change, I wouldn't object.

#4

Updated by Junxiao Shi almost 7 years ago

  • Estimated time changed from 0.50 h to 1.00 h

It's not a "pointless change". It's an improvement which makes code more readable.

#5

Updated by Junxiao Shi almost 7 years ago

  • Status changed from New to In Progress
  • Assignee set to Junxiao Shi
#6

Updated by Junxiao Shi almost 7 years ago

  • Status changed from In Progress to Code review
  • % Done changed from 0 to 100
#7

Updated by Junxiao Shi almost 7 years ago

  • Status changed from Code review to Closed

Also available in: Atom PDF