Project

General

Profile

Actions

Bug #2362

closed

Strategy::beforeSatisfyInterest is not called when PIT is satisfied from CS

Added by Alex Afanasyev over 9 years ago. Updated about 6 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
Forwarding
Target version:
-
Start date:
01/08/2015
Due date:
% Done:

0%

Estimated time:

Description

Without this callback, we not going to have correct stats for interests that are satisfied from CS


Related issues 1 (0 open1 closed)

Blocks NFD - Task #2363: NullFace creation should be moved inside Forwarder constructorAbandoned

Actions
Actions #1

Updated by Alex Afanasyev over 9 years ago

  • Blocks Task #2363: NullFace creation should be moved inside Forwarder constructor added
Actions #2

Updated by Junxiao Shi over 9 years ago

Does the title "Strategy::beforeSatisfyInterest is called when PIT is satisfied from CS" represent expected behavior, or incorrect/actual behavior?

Actions #3

Updated by Alex Afanasyev over 9 years ago

  • Subject changed from Strategy::beforeSatisfyInterest is called when PIT is satisfied from CS to Strategy::beforeSatisfyInterest is not called when PIT is satisfied from CS

I meant to write "is not called". It should be called.

Actions #4

Updated by Junxiao Shi over 9 years ago

  • Status changed from New to Rejected

This behavior is by design.
Strategy::beforeSatisfyInterest is invoked only for incoming Data; ContentStore is not incoming Data.

Forwarding strategy is only responsible for forwarding Interests that cannot be satisfied by ContentStore, and only needs to take measurements for incoming Data.

Actions #5

Updated by Alex Afanasyev over 9 years ago

  • Status changed from Rejected to New

Stop rejecting without proper discussion

Actions #6

Updated by Junxiao Shi over 9 years ago

  • Category set to Forwarding
Actions #7

Updated by Chengyu Fan about 9 years ago

  • Assignee set to Chengyu Fan
Actions #8

Updated by Junxiao Shi about 9 years ago

DO NOT WORK ON THIS ISSUE.

The design is wrong.

Actions #9

Updated by Chengyu Fan about 9 years ago

I see, does it mean that this task needs to be rejected?

Actions #10

Updated by Junxiao Shi about 9 years ago

It's already Rejected in note-4, but someone restored it. Further discussion is needed.

Actions #11

Updated by Chengyu Fan about 9 years ago

I see, will wait for the further discussion.

Actions #12

Updated by Junxiao Shi about 9 years ago

  • Assignee deleted (Chengyu Fan)
Actions #13

Updated by Junxiao Shi about 6 years ago

  • Status changed from New to Rejected

This is no longer relevant. #4290 introduces Strategy::afterContentStoreHit trigger function, and the strategy can collect statistics through this trigger.

Actions

Also available in: Atom PDF